You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/11 20:32:28 UTC

[GitHub] [arrow] westonpace commented on pull request #10919: ARROW-13605: [C++] Use mutexes instead of atomics to avoid TSan warning

westonpace commented on pull request #10919:
URL: https://github.com/apache/arrow/pull/10919#issuecomment-897132048


   I don't think this is the issue.  The node is being destructed but the task spawned on aggregate_node.cc:454 with a weak this pointer is still running.  This is a challenge with gating on `finished_`.  Once `finished_` has been called then nothing is allowed to touch the node's state (because the node is presumably destroyed).
   
   Either the weak this pointer will need to change to a shared_ptr or the logic will need to be massaged so that when `MarkFinished` is called we know that all state access is done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org