You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Kirk Lund <ki...@gmail.com> on 2016/05/10 00:17:23 UTC
Review Request 47143: GEODE-951: repackage
GemFireParameterizedMessage and GemFireParameterizedMessageFactory
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47143/
-----------------------------------------------------------
Review request for geode, Jens Deppe and Jinmei Liao.
Bugs: GEODE-951
https://issues.apache.org/jira/browse/GEODE-951
Repository: geode
Description
-------
GEODE-951: repackage GemFireParameterizedMessage and GemFireParameterizedMessageFactory
* move to package com.gemstone.gemfire.internal.logging.log4j.message
* add javadocs about original source of these classes
* add comments pointing out Geode optimizations in these classes
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/logging/LogService.java 5572d11
geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/LogWriterLogger.java f1e314a
geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/message/GemFireParameterizedMessage.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/message/GemFireParameterizedMessageFactory.java PRE-CREATION
geode-core/src/main/java/com/gemstone/org/apache/logging/log4j/message/GemFireParameterizedMessage.java d638a8c
geode-core/src/main/java/com/gemstone/org/apache/logging/log4j/message/GemFireParameterizedMessageFactory.java f113aa6
Diff: https://reviews.apache.org/r/47143/diff/
Testing
-------
precheckin
Thanks,
Kirk Lund
Re: Review Request 47143: GEODE-951: repackage
GemFireParameterizedMessage and GemFireParameterizedMessageFactory
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47143/#review132379
-----------------------------------------------------------
Ship it!
Ship It!
- Jinmei Liao
On May 10, 2016, 12:20 a.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47143/
> -----------------------------------------------------------
>
> (Updated May 10, 2016, 12:20 a.m.)
>
>
> Review request for geode, Jens Deppe and Jinmei Liao.
>
>
> Bugs: GEODE-951
> https://issues.apache.org/jira/browse/GEODE-951
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-951: repackage GemFireParameterizedMessage and GemFireParameterizedMessageFactory
>
> * move to package com.gemstone.gemfire.internal.logging.log4j.message
> * add javadocs about original source of these classes
> * add comments pointing out Geode optimizations in these classes
>
> Since these files were moved to a new package, I have annotated the two classes to mark the lines with new javadocs or comments.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/LogService.java 5572d11
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/LogWriterLogger.java f1e314a
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/message/GemFireParameterizedMessage.java PRE-CREATION
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/message/GemFireParameterizedMessageFactory.java PRE-CREATION
> geode-core/src/main/java/com/gemstone/org/apache/logging/log4j/message/GemFireParameterizedMessage.java d638a8c
> geode-core/src/main/java/com/gemstone/org/apache/logging/log4j/message/GemFireParameterizedMessageFactory.java f113aa6
>
> Diff: https://reviews.apache.org/r/47143/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Kirk Lund
>
>
Re: Review Request 47143: GEODE-951: repackage
GemFireParameterizedMessage and GemFireParameterizedMessageFactory
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47143/#review132431
-----------------------------------------------------------
Ship it!
Ship It!
- Jens Deppe
On May 10, 2016, 12:20 a.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47143/
> -----------------------------------------------------------
>
> (Updated May 10, 2016, 12:20 a.m.)
>
>
> Review request for geode, Jens Deppe and Jinmei Liao.
>
>
> Bugs: GEODE-951
> https://issues.apache.org/jira/browse/GEODE-951
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-951: repackage GemFireParameterizedMessage and GemFireParameterizedMessageFactory
>
> * move to package com.gemstone.gemfire.internal.logging.log4j.message
> * add javadocs about original source of these classes
> * add comments pointing out Geode optimizations in these classes
>
> Since these files were moved to a new package, I have annotated the two classes to mark the lines with new javadocs or comments.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/LogService.java 5572d11
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/LogWriterLogger.java f1e314a
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/message/GemFireParameterizedMessage.java PRE-CREATION
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/message/GemFireParameterizedMessageFactory.java PRE-CREATION
> geode-core/src/main/java/com/gemstone/org/apache/logging/log4j/message/GemFireParameterizedMessage.java d638a8c
> geode-core/src/main/java/com/gemstone/org/apache/logging/log4j/message/GemFireParameterizedMessageFactory.java f113aa6
>
> Diff: https://reviews.apache.org/r/47143/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Kirk Lund
>
>
Re: Review Request 47143: GEODE-951: repackage
GemFireParameterizedMessage and GemFireParameterizedMessageFactory
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47143/
-----------------------------------------------------------
(Updated May 10, 2016, 12:20 a.m.)
Review request for geode, Jens Deppe and Jinmei Liao.
Bugs: GEODE-951
https://issues.apache.org/jira/browse/GEODE-951
Repository: geode
Description (updated)
-------
GEODE-951: repackage GemFireParameterizedMessage and GemFireParameterizedMessageFactory
* move to package com.gemstone.gemfire.internal.logging.log4j.message
* add javadocs about original source of these classes
* add comments pointing out Geode optimizations in these classes
Since these files were moved to a new package, I have annotated the two classes to mark the lines with new javadocs or comments.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/logging/LogService.java 5572d11
geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/LogWriterLogger.java f1e314a
geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/message/GemFireParameterizedMessage.java PRE-CREATION
geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/message/GemFireParameterizedMessageFactory.java PRE-CREATION
geode-core/src/main/java/com/gemstone/org/apache/logging/log4j/message/GemFireParameterizedMessage.java d638a8c
geode-core/src/main/java/com/gemstone/org/apache/logging/log4j/message/GemFireParameterizedMessageFactory.java f113aa6
Diff: https://reviews.apache.org/r/47143/diff/
Testing
-------
precheckin
Thanks,
Kirk Lund
Re: Review Request 47143: GEODE-951: repackage
GemFireParameterizedMessage and GemFireParameterizedMessageFactory
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47143/#review132358
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/message/GemFireParameterizedMessage.java (line 39)
<https://reviews.apache.org/r/47143/#comment196532>
lines 39-41 are new javadocs
geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/message/GemFireParameterizedMessage.java (line 454)
<https://reviews.apache.org/r/47143/#comment196533>
new comment
geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/message/GemFireParameterizedMessage.java (line 479)
<https://reviews.apache.org/r/47143/#comment196534>
new comment
geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/message/GemFireParameterizedMessage.java (line 554)
<https://reviews.apache.org/r/47143/#comment196536>
new comment
geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/message/GemFireParameterizedMessageFactory.java (line 31)
<https://reviews.apache.org/r/47143/#comment196537>
lines 31-33 are new javadocs
geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/message/GemFireParameterizedMessageFactory.java (line 54)
<https://reviews.apache.org/r/47143/#comment196538>
new comment
- Kirk Lund
On May 10, 2016, 12:17 a.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47143/
> -----------------------------------------------------------
>
> (Updated May 10, 2016, 12:17 a.m.)
>
>
> Review request for geode, Jens Deppe and Jinmei Liao.
>
>
> Bugs: GEODE-951
> https://issues.apache.org/jira/browse/GEODE-951
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-951: repackage GemFireParameterizedMessage and GemFireParameterizedMessageFactory
>
> * move to package com.gemstone.gemfire.internal.logging.log4j.message
> * add javadocs about original source of these classes
> * add comments pointing out Geode optimizations in these classes
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/LogService.java 5572d11
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/LogWriterLogger.java f1e314a
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/message/GemFireParameterizedMessage.java PRE-CREATION
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/message/GemFireParameterizedMessageFactory.java PRE-CREATION
> geode-core/src/main/java/com/gemstone/org/apache/logging/log4j/message/GemFireParameterizedMessage.java d638a8c
> geode-core/src/main/java/com/gemstone/org/apache/logging/log4j/message/GemFireParameterizedMessageFactory.java f113aa6
>
> Diff: https://reviews.apache.org/r/47143/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Kirk Lund
>
>