You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "gortiz (via GitHub)" <gi...@apache.org> on 2023/04/24 06:49:24 UTC
[GitHub] [pinot] gortiz opened a new pull request, #10674: Change getPrettyName() to default to getId()
gortiz opened a new pull request, #10674:
URL: https://github.com/apache/pinot/pull/10674
PR #10623 introduced the new index type concept `prettyName` as a new abstract method.
By adding that we break backward compatibility with no reason. Values of `id` and `prettyName` should be the same unless there is some compatibility reason. For example, most indexes created pre `index-spi` used a different name and id in the older `ColumnIndexType` enum. New indexes should be able to have the same `id` and `prettyName`. Therefore this PR changes `getPrettyName` to delegate on `getId` by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] saurabhd336 merged pull request #10674: Change getPrettyName() to default to getId()
Posted by "saurabhd336 (via GitHub)" <gi...@apache.org>.
saurabhd336 merged PR #10674:
URL: https://github.com/apache/pinot/pull/10674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10674: Change getPrettyName() to default to getId()
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10674:
URL: https://github.com/apache/pinot/pull/10674#issuecomment-1519538636
## [Codecov](https://codecov.io/gh/apache/pinot/pull/10674?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10674](https://codecov.io/gh/apache/pinot/pull/10674?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4c69984) into [master](https://codecov.io/gh/apache/pinot/commit/866c796bd56cf846b654f29f024f3e610557b2c7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (866c796) will **decrease** coverage by `56.43%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #10674 +/- ##
=============================================
- Coverage 70.25% 13.82% -56.43%
+ Complexity 6503 439 -6064
=============================================
Files 2108 2054 -54
Lines 113866 111380 -2486
Branches 17181 16884 -297
=============================================
- Hits 79991 15402 -64589
- Misses 28283 94720 +66437
+ Partials 5592 1258 -4334
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| unittests1 | `?` | |
| unittests2 | `13.82% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/10674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/pinot/segment/spi/index/IndexType.java](https://codecov.io/gh/apache/pinot/pull/10674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3NlZ21lbnQvc3BpL2luZGV4L0luZGV4VHlwZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
... and [1662 files with indirect coverage changes](https://codecov.io/gh/apache/pinot/pull/10674/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org