[jira] [Commented] (TEZ-625) DAG/Vertex names should be restricted to using [A-Za-z0-9_] and limited to a defined character limit

["Hitesh Shah (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609504#comment-14609504 ] 

Hitesh Shah commented on TEZ-625:
---------------------------------

Comments: 
    - StringUtils.repeat() should work. 
    - testDagLongName could combine both invalid and valid checks
    - "if (StringUtils.isBlank(s)) return false;" needs braces
    - "e.printStackTrace();" shouldnt be needed. 
    - Assert.assertTrue() takes a message that can be used to log e.getMessage() in case of assertion failing
    - all the tests probably belong in TestTezCommonUtils as the code is re-used in multiple places with one check for the correct exception being thrown for invalid dag name in TestDAG and likewise for checks for vertex name.
    - some invalid dag names with more than one char would help do a sanity test for the regex.



> DAG/Vertex names should be restricted to using [A-Za-z0-9_] and limited to a defined character limit
> ----------------------------------------------------------------------------------------------------
>
>                 Key: TEZ-625
>                 URL: https://issues.apache.org/jira/browse/TEZ-625
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Hitesh Shah
>            Assignee: Saikat
>              Labels: newbie
>         Attachments: TEZ-625.1.patch, TEZ-625.2.patch, TEZ-625.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)