You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/01/03 11:59:34 UTC

[GitHub] [maven-apache-parent] kwin opened a new pull request #29: MPOM-247 make minimum POM version configurable via property

kwin opened a new pull request #29:
URL: https://github.com/apache/maven-apache-parent/pull/29


   "mavenVersion"


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-apache-parent] kwin commented on pull request #29: [MPOM-247] make minimum POM version configurable via property

Posted by GitBox <gi...@apache.org>.
kwin commented on pull request #29:
URL: https://github.com/apache/maven-apache-parent/pull/29#issuecomment-782897677


   @rfscholte Are you fine with this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-apache-parent] kwin edited a comment on pull request #29: MPOM-247 make minimum POM version configurable via property

Posted by GitBox <gi...@apache.org>.
kwin edited a comment on pull request #29:
URL: https://github.com/apache/maven-apache-parent/pull/29#issuecomment-753613437


   @rfscholte Do you have any examples of usages of `mavenVersion`? I would like to add some comment to make the differences between the two properties clearer. At least in ASF Parent there is no usage of `mavenVersion`.
   
   Update: There is one example usage in https://github.com/apache/maven-release/blob/44ff401499713c981732f3379de2cf6693e0fdef/pom.xml#L92.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-apache-parent] rfscholte commented on pull request #29: MPOM-247 make minimum POM version configurable via property

Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #29:
URL: https://github.com/apache/maven-apache-parent/pull/29#issuecomment-753608853


   There are 2 different meanings for mavenVersion:
   - The version required to build the project
   - The maven compatible version
   
   We use the property for the latter, i.e. using it for dependency versions.
   
   It is very good possible to require Maven4 to create a Maven 3.1 compatible plugin.
   
   So I'm -1
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-apache-parent] asfgit closed pull request #29: [MPOM-247] make minimum Maven version configurable via property

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #29:
URL: https://github.com/apache/maven-apache-parent/pull/29


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-apache-parent] kwin commented on pull request #29: MPOM-247 make minimum POM version configurable via property

Posted by GitBox <gi...@apache.org>.
kwin commented on pull request #29:
URL: https://github.com/apache/maven-apache-parent/pull/29#issuecomment-753630724


   I now use `minimalMavenBuildVersion`, but give it a literal default value, as property `mavenVersion` is not defined in this scope.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-apache-parent] kwin commented on pull request #29: MPOM-247 make minimum POM version configurable via property

Posted by GitBox <gi...@apache.org>.
kwin commented on pull request #29:
URL: https://github.com/apache/maven-apache-parent/pull/29#issuecomment-753613437


   @rfscholte Do you have any examples of usages of `mavenVersion`? I would like to add some comment to make the differences between the two properties clearer. At least in ASF Parent there is no usage of `mavenVersion`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-apache-parent] rfscholte commented on pull request #29: MPOM-247 make minimum POM version configurable via property

Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #29:
URL: https://github.com/apache/maven-apache-parent/pull/29#issuecomment-753611198


   Just a proposal: `<minimalMavenBuildVersion>${mavenVersion}</minimalMavenBuildVersion>`
   Still quite a long name, though
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-apache-parent] rfscholte commented on pull request #29: MPOM-247 make minimum POM version configurable via property

Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #29:
URL: https://github.com/apache/maven-apache-parent/pull/29#issuecomment-753614718


   It is not done at any parent level, but on plugin level. The reason is that prerequisites are not inherited, so you need to define them per plugin.
   But that does make my proposal awkward, I see now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-apache-parent] kwin commented on pull request #29: MPOM-247 make minimum POM version configurable via property

Posted by GitBox <gi...@apache.org>.
kwin commented on pull request #29:
URL: https://github.com/apache/maven-apache-parent/pull/29#issuecomment-753609161


   The property name `mavenVersion` was suggested by @slachiewicz, but I am open for other suggestions to make the intention clearer. What about `mavenRequiredVersionForBuild`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org