You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/07/14 09:41:29 UTC
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11311: [DOCS] function worker docs enhancement
Anonymitaet commented on a change in pull request #11311:
URL: https://github.com/apache/pulsar/pull/11311#discussion_r669456434
##########
File path: site2/website/versioned_sidebars/version-2.8.0-sidebars.json
##########
@@ -25,8 +25,8 @@
],
"Pulsar Functions": [
"version-2.8.0-functions-overview",
- "version-2.8.0-functions-worker",
"version-2.8.0-functions-runtime",
+ "version-2.8.0-functions-worker",
Review comment:
why change the sequence?
##########
File path: site2/website/versioned_docs/version-2.8.0/functions-worker.md
##########
@@ -66,7 +66,7 @@ This section illustrates how to run `functions-worker` as a separate process in
> Note
-> In this mode, make sure `functionsWorkerEnabled` is set to `false`, so you won't start `functions-worker` with brokers by mistake.
+> In this mode, make sure `functionsWorkerEnabled` is set to `false`, so you won't start `functions-worker` with brokers by mistake. Also, while accessing the `functions-worker` to manage any of the functions, the `pulsar-admin` CLI tool or any of the client should use the `workerHostname` and `workerPort` that you set in [Worker parameters](#worker-parameters) to generate an `--admin-url`.
Review comment:
```suggestion
> In this mode, make sure `functionsWorkerEnabled` is set to `false`, so you won't start `functions-worker` with brokers by mistake. Also, while accessing the `functions-worker` to manage any of the functions, the `pulsar-admin` CLI tool or any of the clients should use the `workerHostname` and `workerPort` that you set in [Worker parameters](#worker-parameters) to generate an `--admin-url`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org