You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhishek Kumar <ab...@gmail.com> on 2023/02/06 07:11:38 UTC
Review Request 74297: RANGER-4071: Support for LDAP/AD usernames and groupnames with special chars
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74297/
-----------------------------------------------------------
Review request for ranger and Sailaja Polavarapu.
Bugs: RANGER-4071
https://issues.apache.org/jira/browse/RANGER-4071
Repository: ranger
Description
-------
Ranger usersync regards the forward slash ('/') as a separator character in the regex so it ignores it if you actually want to use it in your groupname. e.g. RRR/group_name_suffix (/ can be potentially used as a domain separator in AD groups)
Using a different character like + in the regex works to get something like RRR+group_name_suffix but not RRR/group_name_suffix.
Diffs
-----
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java 531e35a95
ugsync/src/main/java/org/apache/ranger/usergroupsync/RegEx.java 626df0446
ugsync/src/test/java/org/apache/ranger/usergroupsync/TestRegEx.java d118265ce
Diff: https://reviews.apache.org/r/74297/diff/1/
Testing
-------
mvn clean package on ugsync module.
Thanks,
Abhishek Kumar
Re: Review Request 74297: RANGER-4071: Support for LDAP/AD usernames and groupnames with special chars
Posted by Abhishek Kumar <ab...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74297/
-----------------------------------------------------------
(Updated Feb. 6, 2023, 7:12 a.m.)
Review request for ranger and Sailaja Polavarapu.
Bugs: RANGER-4071
https://issues.apache.org/jira/browse/RANGER-4071
Repository: ranger
Description
-------
Ranger usersync regards the forward slash ('/') as a separator character in the regex so it ignores it if you actually want to use it in your groupname. e.g. RRR/group_name_suffix (/ can be potentially used as a domain separator in AD groups)
Using a different character like + in the regex works to get something like RRR+group_name_suffix but not RRR/group_name_suffix.
Diffs
-----
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java 531e35a95
ugsync/src/main/java/org/apache/ranger/usergroupsync/RegEx.java 626df0446
ugsync/src/test/java/org/apache/ranger/usergroupsync/TestRegEx.java d118265ce
Diff: https://reviews.apache.org/r/74297/diff/1/
Testing (updated)
-------
Added unit test for the new feature.
mvn clean package on ugsync module.
Thanks,
Abhishek Kumar