You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2017/12/05 08:47:00 UTC
[jira] [Commented] (RATIS-166) Remove the use of sun.misc.Unsafe
[ https://issues.apache.org/jira/browse/RATIS-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278208#comment-16278208 ]
Hadoop QA commented on RATIS-166:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 8s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 49s{color} | {color:green} root generated 0 new + 100 unchanged - 7 fixed = 100 total (was 107) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 19s{color} | {color:orange} root: The patch generated 2 new + 428 unchanged - 7 fixed = 430 total (was 435) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 9m 54s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 8s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 15m 29s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2017-12-05 |
| JIRA Issue | RATIS-166 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12900634/r166_20171205.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle compile |
| uname | Linux 6cc820f71195 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh |
| git revision | master / 1028c19 |
| Default Java | 1.8.0_151 |
| checkstyle | https://builds.apache.org/job/PreCommit-RATIS-Build/58/artifact/out/diff-checkstyle-root.txt |
| Test Results | https://builds.apache.org/job/PreCommit-RATIS-Build/58/testReport/ |
| modules | C: ratis-common U: ratis-common |
| Console output | https://builds.apache.org/job/PreCommit-RATIS-Build/58/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> Remove the use of sun.misc.Unsafe
> ---------------------------------
>
> Key: RATIS-166
> URL: https://issues.apache.org/jira/browse/RATIS-166
> Project: Ratis
> Issue Type: Improvement
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Kit Hui
> Attachments: r166_20171205.patch
>
>
> sun.misc.Unsafe is used in NativeIO. However, all the methods using Unsafe are not used anywhere in Ratis. Since the use of Unsafe generates some javac warning, let's remove those methods from NativeIO.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)