You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/12 12:21:02 UTC
[jira] [Commented] (AVRO-2114) Make missing value exceptions in
nested structures easier to read.
[ https://issues.apache.org/jira/browse/AVRO-2114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287525#comment-16287525 ]
ASF GitHub Bot commented on AVRO-2114:
--------------------------------------
GitHub user nielsbasjes opened a pull request:
https://github.com/apache/avro/pull/263
AVRO-2114: Make missing value exceptions in nested structures easier to read.
With this patch the exception of a missing nested fields looks like this below.
The developer can now clearly see the path in the schema where the problem occurred.
Please review.
```
Field networkAddress type:STRING pos:1 not set and has no default value
Path in schema: --> connection --> networkAddress
at org.apache.avro.generic.GenericData.getDefaultValue(GenericData.java:999)
at org.apache.avro.data.RecordBuilderBase.defaultValue(RecordBuilderBase.java:138)
at org.apache.avro.test.http.NetworkConnection$Builder.build(NetworkConnection.java:290)
at org.apache.avro.test.http.Request$Builder.build(Request.java:440)
at org.apache.avro.specific.TestSpecificBuilderTree.failOnIncompleteTree(TestSpecificBuilderTree.java:78)
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nielsbasjes/avro AVRO-2114
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/avro/pull/263.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #263
----
commit 830b10627dbffc6d054579e250bfafc603f55e49
Author: Niels Basjes <nb...@bol.com>
Date: 2017-12-12T12:09:40Z
AVRO-2114: Make missing value exceptions in nested structures easier to read.
----
> Make missing value exceptions in nested structures easier to read.
> ------------------------------------------------------------------
>
> Key: AVRO-2114
> URL: https://issues.apache.org/jira/browse/AVRO-2114
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Niels Basjes
> Assignee: Niels Basjes
> Priority: Minor
> Fix For: 1.9.0
>
>
> If you have in Java the generated SpecificRecord structure and it has nested fields then finding the cause of the problem takes a while. The cause is that the system wraps the deeper runtime exception in another runtime exception and in the end it can become too much to dig through.
> Goal: make the exception in this kind of scenario easier to read.
> If you let this test fail https://github.com/apache/avro/blob/master/lang/java/ipc/src/test/java/org/apache/avro/specific/TestSpecificBuilderTree.java#L75 the stacktrace you get looks like this:
> {code}
> org.apache.avro.AvroRuntimeException: org.apache.avro.AvroRuntimeException: org.apache.avro.AvroRuntimeException: Field networkAddress type:STRING pos:1 not set and has no default value
> at org.apache.avro.test.http.Request$Builder.build(Request.java:450)
> at org.apache.avro.specific.TestSpecificBuilderTree.failOnIncompleteTree(TestSpecificBuilderTree.java:77)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
> at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
> at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
> at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
> Caused by: org.apache.avro.AvroRuntimeException: org.apache.avro.AvroRuntimeException: Field networkAddress type:STRING pos:1 not set and has no default value
> at org.apache.avro.test.http.NetworkConnection$Builder.build(NetworkConnection.java:293)
> at org.apache.avro.test.http.Request$Builder.build(Request.java:439)
> ... 23 more
> Caused by: org.apache.avro.AvroRuntimeException: Field networkAddress type:STRING pos:1 not set and has no default value
> at org.apache.avro.generic.GenericData.getDefaultValue(GenericData.java:998)
> at org.apache.avro.data.RecordBuilderBase.defaultValue(RecordBuilderBase.java:138)
> at org.apache.avro.test.http.NetworkConnection$Builder.build(NetworkConnection.java:290)
> ... 24 more
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)