You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2021/02/16 15:21:54 UTC

[GitHub] [jackrabbit-oak] mreutegg opened a new pull request #276: OAK-9358: DocumentNodeStore may accumulate split candidates

mreutegg opened a new pull request #276:
URL: https://github.com/apache/jackrabbit-oak/pull/276


   Fix issue and enable tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit-oak] mreutegg closed pull request #276: OAK-9358: DocumentNodeStore may accumulate split candidates

Posted by GitBox <gi...@apache.org>.
mreutegg closed pull request #276:
URL: https://github.com/apache/jackrabbit-oak/pull/276


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit-oak] stefan-egli commented on pull request #276: OAK-9358: DocumentNodeStore may accumulate split candidates

Posted by GitBox <gi...@apache.org>.
stefan-egli commented on pull request #276:
URL: https://github.com/apache/jackrabbit-oak/pull/276#issuecomment-780494223


   @mreutegg PS: I can't close this PR - jira ticket is marked as resolved though


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit-oak] stefan-egli commented on pull request #276: OAK-9358: DocumentNodeStore may accumulate split candidates

Posted by GitBox <gi...@apache.org>.
stefan-egli commented on pull request #276:
URL: https://github.com/apache/jackrabbit-oak/pull/276#issuecomment-780469229


   Merged in [1886615](http://svn.apache.org/viewvc?rev=1886615&view=rev)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit-oak] stefan-egli commented on a change in pull request #276: OAK-9358: DocumentNodeStore may accumulate split candidates

Posted by GitBox <gi...@apache.org>.
stefan-egli commented on a change in pull request #276:
URL: https://github.com/apache/jackrabbit-oak/pull/276#discussion_r577506368



##########
File path: oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java
##########
@@ -2527,8 +2527,8 @@ private void backgroundSplit() {
             invalidatePaths(pathsToInvalidate);
             batchSplit(splitOpsPhase1);
             batchSplit(splitOpsPhase2);
-            splitCandidates.keySet().removeAll(removeCandidates);
         }
+        splitCandidates.keySet().removeAll(removeCandidates);

Review comment:
       This fixes indeed a regression, nice catch! (The above change fixes an older bug, that was there before)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org