[jira] [Commented] (ACCUMULO-3172) mavanagaiata plugin marks releases "dirty"

["Mike Drob (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148370#comment-14148370 ] 

Mike Drob commented on ACCUMULO-3172:
-------------------------------------

We switched because (at the time?) buildnumber did not work correctly with git.

> mavanagaiata plugin marks releases "dirty"
> ------------------------------------------
>
>                 Key: ACCUMULO-3172
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3172
>             Project: Accumulo
>          Issue Type: Bug
>          Components: build
>            Reporter: Christopher Tubbs
>            Assignee: Christopher Tubbs
>             Fix For: 1.5.3, 1.6.2, 1.7.0
>
>
> The mavanagaiata plugin we use to populate the build number in the META-INF/MANIFEST.MF file appends "-dirty" to the git commit hash. I believe this is probably done because the release plugin is adding additional files to the working branch, but I can't be sure.
> We should alter the build such that the MANIFEST.MF files don't indicate it was built from a dirty state when it wasn't.
> Further, if possible, we should fail the release:prepare goal if it tries to build from a dirty state initially. I know this was a feature of the buildnumber-maven-plugin, but it doesn't appear to be an option for this mavanagaiata one (why did we switch when we added this field back to the manifest files?)
> See https://github.com/koraktor/mavanagaiata/issues/34



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)