You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "franciscoabsampaio (via GitHub)" <gi...@apache.org> on 2026/05/06 17:45:59 UTC
Re: [PR] Add Spark 4 protobuf definitions and basic working [spark-connect-rust]
franciscoabsampaio commented on PR #11:
URL: https://github.com/apache/spark-connect-rust/pull/11#issuecomment-4390578689
Hi!
Thanks for the contribution.
I am, in general, against solutions that involve hardcoding the Spark version to the crate's internals.
Spark 3 is also still the most widely used version (and definitely the most mature), so I am of the opinion that the Rust crate should support different versions.
Of course, as functionality changes significantly, support for older versions can (and should) drop, but since this crate doesn't even have a 1.0 release, it seems too rushed to move to Spark 4 already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org