[GitHub] [hadoop] arp7 commented on a change in pull request #884: HDDS-1620. Implement Volume Write Requests to use Cache and DoubleBuffer.

[GitBox <gi...@apache.org>]

arp7 commented on a change in pull request #884: HDDS-1620. Implement Volume Write Requests to use Cache and DoubleBuffer.
URL: https://github.com/apache/hadoop/pull/884#discussion_r291756985
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientRequest.java
 ##########
 @@ -180,6 +181,17 @@ protected OMResponse createErrorOMResponse(OMResponse.Builder omResponse,
     return omResponse.build();
   }
 
+
+  /*
+   * This method sets the omRequest. This will method will be called when
 
 Review comment:
   @bharatviswa504 can we eliminate this method as a requirement for implementors to call. Since the preExecute always returns an OM request, the caller can take the result and update omRequest.
   
   It would be a good idea to minimize the work done by preExecute/validateAndUpdateCache and make as much common as possible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org