You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@madlib.apache.org by lifepillar <gi...@git.apache.org> on 2016/11/24 20:31:39 UTC

[GitHub] incubator-madlib pull request #76: Include boost::format in MathToolkit_impl...

GitHub user lifepillar opened a pull request:

    https://github.com/apache/incubator-madlib/pull/76

    Include boost::format in MathToolkit_impl.hpp.

    Without this include, compilation fails on macOS Sierra with the following
    error:
    
    In file included from /tmp/incubator-madlib-e1c99c1/src/dbal/BoostIntegration/BoostIntegration.hpp:25:
    /tmp/incubator-madlib-e1c99c1/src/dbal/BoostIntegration/MathToolkit_impl.hpp:56:22: error: no member named 'io' in
          namespace 'boost'
                % boost::io::group(std::setprecision(prec), inVal)
                  ~~~~~~~^
    /tmp/incubator-madlib-e1c99c1/src/dbal/BoostIntegration/MathToolkit_impl.hpp:55:31: error: no member named 'format' in
          namespace 'boost'
        std::string msg = (boost::format(inMessage)
                           ~~~~~~~^
    2 errors generated.
    make[2]: *** [src/ports/postgres/9.6/CMakeFiles/madlib_postgresql_9_6.dir/__/__/__/modules/assoc_rules/assoc_rules.cpp.o] Error 1
    make[1]: *** [src/ports/postgres/9.6/CMakeFiles/madlib_postgresql_9_6.dir/all] Error 2
    make: *** [all] Error 2

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lifepillar/incubator-madlib boost-format

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-madlib/pull/76.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #76
    
----
commit fd2f3b15930a2144acd6f9b184b91fb71dad2568
Author: Lifepillar <li...@lifepillar.me>
Date:   2016-11-24T20:15:39Z

    Include boost::format in MathToolkit_impl.hpp.
    
    Without this include, compilation fails on macOS Sierra with the following
    error:
    
    In file included from /tmp/incubator-madlib-e1c99c1/src/dbal/BoostIntegration/BoostIntegration.hpp:25:
    /tmp/incubator-madlib-e1c99c1/src/dbal/BoostIntegration/MathToolkit_impl.hpp:56:22: error: no member named 'io' in
          namespace 'boost'
                % boost::io::group(std::setprecision(prec), inVal)
                  ~~~~~~~^
    /tmp/incubator-madlib-e1c99c1/src/dbal/BoostIntegration/MathToolkit_impl.hpp:55:31: error: no member named 'format' in
          namespace 'boost'
        std::string msg = (boost::format(inMessage)
                           ~~~~~~~^
    2 errors generated.
    make[2]: *** [src/ports/postgres/9.6/CMakeFiles/madlib_postgresql_9_6.dir/__/__/__/modules/assoc_rules/assoc_rules.cpp.o] Error 1
    make[1]: *** [src/ports/postgres/9.6/CMakeFiles/madlib_postgresql_9_6.dir/all] Error 2
    make: *** [all] Error 2

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-madlib issue #76: Include boost::format in MathToolkit_impl.hpp.

Posted by fmcquillan99 <gi...@git.apache.org>.

Github user fmcquillan99 commented on the issue:

    https://github.com/apache/incubator-madlib/pull/76
  
    Thanks for the PR.  Part of:
    Support for PostgreSQL 9.6 on all supported platforms incl macOS Sierra
    https://issues.apache.org/jira/browse/MADLIB-1046



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-madlib issue #76: Include boost::format in MathToolkit_impl.hpp.

Posted by iyerr3 <gi...@git.apache.org>.

Github user iyerr3 commented on the issue:

    https://github.com/apache/incubator-madlib/pull/76
  
    Merged with 0e00a27. Need to close this PR (either by @lifepillar or via a future commit message)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-madlib pull request #76: Include boost::format in MathToolkit_impl...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-madlib/pull/76


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---