You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/22 16:56:00 UTC

[jira] [Commented] (FLINK-6357) ParameterTool get unrequested parameters

    [ https://issues.apache.org/jira/browse/FLINK-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059683#comment-16059683 ] 

ASF GitHub Bot commented on FLINK-6357:
---------------------------------------

GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/4169

    [FLINK-6357] [java] ParameterTool get unrequested parameters

    Adds ParameterTool#getUnrequestedParameters returning a Set<String> of parameter arguments names not yet requested by ParameterTool#has or any of the ParameterTool#get methods.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 6357_parametertool_get_unrequested_parameters

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4169.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4169
    
----
commit c981ad4ffe828396d5c038465ace17637b585f8f
Author: Greg Hogan <co...@greghogan.com>
Date:   2017-06-21T12:18:55Z

    [FLINK-6357] [java] ParameterTool get unrequested parameters
    
    Adds ParameterTool#getUnrequestedParameters returning a Set<String> of
    parameter arguments names not yet requested by ParameterTool#has or any
    of the ParameterTool#get methods.

----


> ParameterTool get unrequested parameters
> ----------------------------------------
>
>                 Key: FLINK-6357
>                 URL: https://issues.apache.org/jira/browse/FLINK-6357
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API
>    Affects Versions: 1.3.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Minor
>
> The Gelly examples use {{ParameterTool}} to parse required and optional parameters. In the latter case we should detect if a user mistypes a parameter name. I would like to add a {{Set<String> getUnrequestedParameters()}} method returning parameter names not requested by {{has}} or any of the {{get}} methods.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)