You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/01/12 21:40:04 UTC
[I] Test failure in sqllogictest test_files/aggregate.slt:2566 on Mac [arrow-datafusion]
alamb opened a new issue, #8845:
URL: https://github.com/apache/arrow-datafusion/issues/8845
### Describe the bug
sqllogic
```
External error: query result mismatch:
[SQL] select trace_id, other, MIN(timestamp) from traces group by trace_id, other order by MIN(timestamp) asc limit 4;
[Diff] (-expected|+actual)
a -1 -1
b 0 0
NULL 0 0
- c 1 1
+ a 1 1
at test_files/aggregate.slt:2566
```
### To Reproduce
I run this on my Mac M3:
```
cargo test --test sqllogictests
```
### Expected behavior
The test should pass
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Test failure in sqllogictest `aggregates_topk.slt` on mac [arrow-datafusion]
Posted by "mustafasrepo (via GitHub)" <gi...@apache.org>.
mustafasrepo closed issue #8845: Test failure in sqllogictest `aggregates_topk.slt` on mac
URL: https://github.com/apache/arrow-datafusion/issues/8845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Test failure in sqllogictest `aggregates_topk.slt` on mac [arrow-datafusion]
Posted by "avantgardnerio (via GitHub)" <gi...@apache.org>.
avantgardnerio commented on issue #8845:
URL: https://github.com/apache/arrow-datafusion/issues/8845#issuecomment-1910317495
@alamb , sorry for the flaky test 😞 . I can think of two solutions:
1. turn this into a unit test that asserts content, but not order
2. go all the way and implement multiple order bys with `OwnedRow` and add a 2nd order by to the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Test failure in sqllogictest `aggregates_topk.slt` on mac [arrow-datafusion]
Posted by "mustafasrepo (via GitHub)" <gi...@apache.org>.
mustafasrepo commented on issue #8845:
URL: https://github.com/apache/arrow-datafusion/issues/8845#issuecomment-1910344427
> What about changing timestamp field in the table so that, it is unique (hence `MIN(timestamp)` will generate different results for each different distinct group).
Filed a mini [PR8993](https://github.com/apache/arrow-datafusion/pull/8993) implementing this suggestion. It will be nice if you have time to double check whether result is indeed deterministic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Test failure in sqllogictest `aggregates_topk.slt` on mac [arrow-datafusion]
Posted by "mustafasrepo (via GitHub)" <gi...@apache.org>.
mustafasrepo commented on issue #8845:
URL: https://github.com/apache/arrow-datafusion/issues/8845#issuecomment-1910330231
What about changing timestamp field in the table so that, it is unique (hence `order by MIN(timestamp)` will be deterministic. Given that groups are distinct).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Test failure in sqllogictest `aggregates_topk.slt` on mac [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #8845:
URL: https://github.com/apache/arrow-datafusion/issues/8845#issuecomment-1910092761
@mustafasrepo moved this intermittent test to aggregates_topk.slt to isolate the problem more in https://github.com/apache/arrow-datafusion/pull/8948
@avantgardnerio this is now coming up in new PRs -- e.g. https://github.com/apache/arrow-datafusion/pull/8993
Can you suggest some way to make these tests deterministic (maybe we need to add a few more rows or adjust N so the top K rows are well defined in all cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org