You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/11/08 00:14:58 UTC
[GitHub] brodybits commented on a change in pull request #300: Only copy
platform node_modules when created by binary
brodybits commented on a change in pull request #300: Only copy platform node_modules when created by binary
URL: https://github.com/apache/cordova-windows/pull/300#discussion_r231726538
##########
File path: bin/lib/create.js
##########
@@ -74,7 +74,7 @@ module.exports.create = function (destinationDir, config, options) {
// copy node_modules to cordova directory
events.emit('verbose', 'Copying node_modules to ' + projectPath);
- shell.cp('-r', path.join(root, 'node_modules'), path.join(projectPath, 'cordova'));
+ if (options.copyPlatformNodeModules) shell.cp('-r', path.join(root, 'node_modules'), path.join(projectPath, 'cordova'));
Review comment:
I would have split this up (minor)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org