[GitHub] [superset] AAfghahi commented on a diff in pull request #20338: chore: removing Druid from front- and back- end

[GitBox <gi...@apache.org>]

AAfghahi commented on code in PR #20338:
URL: https://github.com/apache/superset/pull/20338#discussion_r915067383


##########
superset-frontend/src/explore/controlUtils/getSectionsToRender.ts:
##########
@@ -56,9 +56,9 @@ const getMemoizedSectionsToRender = memoizeOne(
 
     // list of datasource-specific controls that should be removed
     const invalidControls =
-      datasourceType === 'table'
-        ? ['granularity', 'druid_time_origin']
-        : ['granularity_sqla', 'time_grain_sqla'];
+      datasourceType !== 'table'
+        ? ['granularity_sqla', 'time_grain_sqla']
+        : ['granularity'];

Review Comment:
   yeah, it would read better for sure. I will once the test suite runs fully. Wanna see if there is anything I am missing
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org