You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mikhail Khludnev (JIRA)" <ji...@apache.org> on 2015/09/23 09:42:05 UTC
[jira] [Reopened] (SOLR-7730) speed-up faceting on doc values
fields
[ https://issues.apache.org/jira/browse/SOLR-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Khludnev reopened SOLR-7730:
------------------------------------
Assignee: Mikhail Khludnev
{{SlowCompositeReaderWrapper }} in {{lucene-core-5.3.0.jar}} still has slow implementation
{code}
public SortedDocValues getSortedDocValues(java.lang.String)
...
105: aload_0
106: invokevirtual #39 // Method getFieldInfos:()Lorg/apache/lucene/index/FieldInfos;
109: aload_1
110: invokevirtual #40 // Method org/apache/lucene/index/FieldInfos.fieldInfo:(Ljava/lang/String;)Lorg/apache/lucene/index/FieldInfo;
113: invokevirtual #41 // Method org/apache/lucene/index/FieldInfo.getDocValuesType:()Lorg/apache/lucene/index/DocValuesType;
116: getstatic #42 // Field org/apache/lucene/index/DocValuesType.SORTED:Lorg/apache/lucene/index/DocValuesType;
119: if_acmpeq 124
122: aconst_null
123: areturn
...
{code}
I missed something.
> speed-up faceting on doc values fields
> --------------------------------------
>
> Key: SOLR-7730
> URL: https://issues.apache.org/jira/browse/SOLR-7730
> Project: Solr
> Issue Type: Improvement
> Components: faceting
> Affects Versions: 5.2.1
> Reporter: Mikhail Khludnev
> Assignee: Mikhail Khludnev
> Labels: patch
> Fix For: 5.3
>
> Attachments: LUCENE-7730.patch, LUCENE-7730.patch, SOLR-7730.patch
>
>
> every time we count facets on DocValues fields in Solr on many segments index we see the unnecessary hotspot:
> {code}
> ....
> at org.apache.lucene.index.MultiFields.getMergedFieldInfos(MultiFields.java:248)
> at org.apache.lucene.index.SlowCompositeReaderWrapper.getFieldInfos(SlowCompositeReaderWrapper.java:239)
> at org.apache.lucene.index.SlowCompositeReaderWrapper.getSortedSetDocValues(SlowCompositeReaderWrapper.java:176)
> at org.apache.solr.request.DocValuesFacets.getCounts(DocValuesFacets.java:72)
> at org.apache.solr.request.SimpleFacets.getTermCounts(SimpleFacets.java:460) ....
> {code}
> the reason is SlowCompositeReaderWrapper.getSortedSetDocValues() Line 136 and SlowCompositeReaderWrapper.getSortedDocValues() Line 174
> before return composite doc values, SCWR merges segment field infos, which is expensive, but after fieldinfo is merged, it checks *only* docvalue type in it. This dv type check can be done much easier in per segment basis.
> This patch gets some performance gain for those who count DV facets in Solr.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org