[GitHub] [ozone] duongkame commented on a diff in pull request #4044: HDDS-7517. Register OM-S3G gRPC performance metrics

[GitBox <gi...@apache.org>]

duongkame commented on code in PR #4044:
URL: https://github.com/apache/ozone/pull/4044#discussion_r1065397764


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/grpc/GrpcOmServerRequestInterceptor.java:
##########
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.ozone.om.grpc;
+
+import org.apache.commons.io.IOUtils;
+import org.apache.hadoop.ozone.om.grpc.metrics.GrpcOzoneManagerMetrics;
+import io.grpc.ForwardingServerCallListener.SimpleForwardingServerCallListener;
+import io.grpc.Metadata;
+import io.grpc.ServerCall;
+import io.grpc.ServerCallHandler;
+import io.grpc.ServerInterceptor;
+
+import java.io.ByteArrayOutputStream;
+import java.io.ObjectOutputStream;
+import java.io.InputStream;
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
+import java.nio.ByteBuffer;
+
+/**
+ * Interceptor to gather metrics based on grpc server request.
+ */
+public class GrpcOmServerRequestInterceptor implements ServerInterceptor {
+
+  private final GrpcOzoneManagerMetrics grpcMetrics;
+  private long bytesReceived;
+  private long receivedTime;
+  private long startTime;
+  private long endTime;
+
+  public GrpcOmServerRequestInterceptor(
+      GrpcOzoneManagerMetrics grpcMetrics) {
+    super();
+    this.grpcMetrics = grpcMetrics;
+    this.bytesReceived = 0;
+  }
+
+  @Override
+  public <ReqT, RespT> ServerCall.Listener<ReqT> interceptCall(
+      ServerCall<ReqT, RespT> serverCall, Metadata headers,
+      ServerCallHandler<ReqT, RespT> serverCallHandler) {
+
+    // received time
+    receivedTime = System.nanoTime();
+
+    return new SimpleForwardingServerCallListener<ReqT>(
+        serverCallHandler.startCall(serverCall, headers)) {
+
+      @Override
+      public void onMessage(ReqT message) {
+        // start time
+        startTime = System.nanoTime();
+
+        ByteArrayOutputStream byteArrayOutputStream =
+            new ByteArrayOutputStream();
+        try {
+          ObjectOutputStream outputStream =
+              new ObjectOutputStream(byteArrayOutputStream);
+          outputStream.writeObject(message);

Review Comment:
   Thanks, @xBis7, and sorry that I lost focus on this PR.
   
   I see you've changed to use `message.toString()` to count the bytes.
   
   Actually, I did a bit of homework to trace the actual type of such message objects passed to the GRPC listeners. It looks to me that when using GRPC with Protobuf, the messages are parsed to Protobuf-generated classes, e.g. `AllocateBlockRequest` or `AllocateBlockResponse`. And those classes extend the same class `com.google.protobuf.AbstractMessage`, which is a lot easier to extract information like message size.
   
   So, if we check and safely cast to `AbstractMessage`, the message size can be extracted like below:
   ```
   int getMessageSize(Object message) {
      if (message instanceof AbstractMessage) {
         AbstractMessage parsedMessage = (AbstractMessage) message;
         return parsedMessage.getSerializedSize();
      }
     // otherwise maybe just return 0, or fall back calculation.
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org