You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2018/06/08 12:04:12 UTC

[GitHub] tinkerpop pull request #873: TINKERPOP-1518 Cache Graph.Features for tests

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/873

    TINKERPOP-1518 Cache Graph.Features for tests

    https://issues.apache.org/jira/browse/TINKERPOP-1518
    
    For graphs that have an expensive startup time but a static set of `Graph.Features` the new `GraphProvider.getStaticFeatures()` method should help speed their test times as it will prevent creation of a new `Graph` instance for the test if the graph does not support the requisite features. For testing purposes, this capability was implemented for Neo4j, but it didn't do much to speed the execution time of the test suite - saved a couple minutes or so. It's generally pretty cheap to create Neo4j instances themselves, so I guess that is expected.
    
    (just issued the PR, not quite ready for VOTE yet)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1518

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/873.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #873
    
----
commit aec170982aa03d1a07248721cb045ba95e11188b
Author: Stephen Mallette <sp...@...>
Date:   2018-06-08T00:15:53Z

    TINKERPOP-1518 GraphProvider allows for caching of graph features

commit 221fda584c6baf7c65eb4e6eebf72bb0ba251de4
Author: Stephen Mallette <sp...@...>
Date:   2018-06-08T11:45:29Z

    TINKERPOP-1518 Minor refactoring - extracted requirement check function

----


---

[GitHub] tinkerpop issue #873: TINKERPOP-1518 Cache Graph.Features for tests

Posted by jorgebay <gi...@git.apache.org>.

Github user jorgebay commented on the issue:

    https://github.com/apache/tinkerpop/pull/873
  
    Nice doc on the new method, VOTE +1 


---

[GitHub] tinkerpop issue #873: TINKERPOP-1518 Cache Graph.Features for tests

Posted by spmallette <gi...@git.apache.org>.

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/873
  
    Good point - updated to "Provide a way for providers to expose static Graph.Features to tests"


---

[GitHub] tinkerpop pull request #873: TINKERPOP-1518 Cache Graph.Features for tests

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/tinkerpop/pull/873


---

[GitHub] tinkerpop issue #873: TINKERPOP-1518 Cache Graph.Features for tests

Posted by dkuppitz <gi...@git.apache.org>.

Github user dkuppitz commented on the issue:

    https://github.com/apache/tinkerpop/pull/873
  
    VOTE: +1
    
    Though I would change the Jira ticket title before it makes it into the CHANGELOG, as the implementation doesn't really cache anything.


---