[GitHub] azai91 commented on a change in pull request #12560: Fix/test activation

[GitBox <gi...@apache.org>]

azai91 commented on a change in pull request #12560: Fix/test activation
URL: https://github.com/apache/incubator-mxnet/pull/12560#discussion_r217747343
 
 

 ##########
 File path: tests/python/mkl/test_mkldnn.py
 ##########
 @@ -292,7 +291,7 @@ def check_activation_training(stype):
             in_location = [mx.nd.array(data_tmp).tostype(stype)]
 
             test = mx.symbol.Activation(data, act_type="relu")
-            check_numeric_gradient(test, in_location, numeric_eps=1e-2, rtol=0.16, atol=1e-4)
+            check_numeric_gradient(test, in_location, numeric_eps=1e-5, rtol=0.16, atol=1e-4)
 
 Review comment:
   there's a significant difference between using 1e-5 vs 1e-6. I commented in https://github.com/apache/incubator-mxnet/issues/12377. in short, you should never use anything less than 1e-5 as the floats do not have enough precision to calculate the difference in the numerator.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services