You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/11/30 10:22:12 UTC
[GitHub] [qpid-broker-j] dakirily opened a new pull request #73: QPID-8489 - Connection thread looping
dakirily opened a new pull request #73:
URL: https://github.com/apache/qpid-broker-j/pull/73
The main problem with connection loss is that it's difficult to detect invalidity of the connection programmatically based on state of java.nio.channels.Selector / java.nio.channels.SelectionKey / java.nio.channels.ServerSocketChannel. One of the clues allowing to suspect that connection is lost are the times of last read and last write of _protocolEngine variable, as they don't change and remain same during loop iterations.
I suggest to implement new Ticker implementation which will detect lost connections by checking whether actual read / write operation were performed or not and if they weren't, it will send a heartbeat signal to the lost connection. That will invalidate it (broken pipe) and end the looping.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-broker-j] asfgit closed pull request #73: QPID-8489 - Connection thread looping
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #73:
URL: https://github.com/apache/qpid-broker-j/pull/73
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org