How to go about confirming a possible bug and contributing updates to a document

["Jay Wren (jawren)" <ja...@cisco.com.INVALID>]

Hello,

I hope this message finds you well.

First, I want to thank you for https://www.openoffice.org/sc/excelfileformat.pdf I have found it invaluable. Thank you.

I wanted to ask about a possible bug or submitting a patch to this document. I think I may have found an error in the size table in section 3.4.7. Specifically, tFunc and tFuncVar on page 43. The BIFF8 size is listed at 4 and 5 respectively. However, in section 3.7.1 and 3.7.2 only 3 bytes and 4 bytes respectively are documented. Indeed in practice as I write a parser, I can only read 4 bytes and not 5 for tFuncVar.

If I missed something, I’d love to be corrected. If I did not, I’d love to contribute if you suggest.

Thanks,
—
Jay Wren

Possible error in File https://www.openoffice.org/sc/excelfileformat.pdf (was: How to go about confirming a possible bug and contributing updates to a document )

[Peter Kovacs <pe...@apache.org>]

Hello Jay,

Am 21.10.20 um 16:49 schrieb Jay Wren (jawren):
> Hello,
>
> I hope this message finds you well.
>
> First, I want to thank you for https://www.openoffice.org/sc/excelfileformat.pdf I have found it invaluable. Thank you.
You are welcome. It is good to know that people take interest in our 
pages. :)
> I wanted to ask about a possible bug or submitting a patch to this document. I think I may have found an error in the size table in section 3.4.7. Specifically, tFunc and tFuncVar on page 43. The BIFF8 size is listed at 4 and 5 respectively. However, in section 3.7.1 and 3.7.2 only 3 bytes and 4 bytes respectively are documented. Indeed in practice as I write a parser, I can only read 4 bytes and not 5 for tFuncVar.

I am not sure if we have a editable Document somewhere. I switch from 
recruitment to dev List. Maybe someone knows if we have an better editor 
able file that we can provide you for a fix..

I am not sure, but our code reads 4 Tokes Int16. I do not see a fifth. 
So this sounds according to your observation.

http://opengrok.openoffice.org/xref/trunk/main/oox/source/xls/formulaparser.cxx?r=a893be29#importFuncVarToken4

I am not sure if Apache POI has also some input on this? I am a bit 
unfamiliar with their Project.


*Dave*

you have some idea how to quickly search the POI Code?


> If I missed something, I’d love to be corrected. If I did not, I’d love to contribute if you suggest.

Contribution are all welcome. I think it is best to create a ticket in 
Bugzilla, upload your patch there. And bring then the case to an 
attention on the dev list, by answering to this thread with the ticket.

Just for better awarness. :)


all the best

Peter


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org