[GitHub] [incubator-weex] weex-bot commented on issue #3161: refine code structure for eagle

[GitBox <gi...@apache.org>]

weex-bot commented on issue #3161: refine code structure for eagle
URL: https://github.com/apache/incubator-weex/pull/3161#issuecomment-594530390
 
 
   
   <!--
     1 failure:  Code file weex_co...
     6 warning:  Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., No Changelog chan..., Current pr not bi..., If your PR is abo...
     
     
     DangerID: danger-id-danger;
   -->
   
   <table>
     <thead>
       <tr>
         <th width="50"></th>
         <th width="100%" data-danger-table="true">Fails</th>
       </tr>
     </thead>
     <tbody><tr>
         <td>:no_entry_sign:</td>
         <td>
   
     Code file weex_core/Source/core/bridge/eagle_bridge.h has cn source code.
     </td>
       </tr>
     </tbody>
   </table>
   
   
   <table>
     <thead>
       <tr>
         <th width="50"></th>
         <th width="100%" data-danger-table="true">Warnings</th>
       </tr>
     </thead>
     <tbody><tr>
         <td>:warning:</td>
         <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/org/apache/weex/WXSDKInstance.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/org/apache/weex/bridge/WXBridge.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/org/apache/weex/bridge/WXModuleManager.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>No Changelog changes! - <i>Can you add a Changelog? To do so,append your changes to the changelog.md</i></td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>Current pr not bind the milestone</td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: <a href='http://dotwe.org/vue'>http://dotwe.org/vue</a></td>
       </tr>
     </tbody>
   </table>
   
   
   
   <p align="right">
     Generated by :no_entry_sign: <a href="https://danger.systems/js">dangerJS</a> against 2ded50b6759fdee8627870f15b1e6fc8dad060f0
   </p>
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services