[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5747: Client consistency

[GitBox <gi...@apache.org>]

ocket8888 commented on a change in pull request #5747:
URL: https://github.com/apache/trafficcontrol/pull/5747#discussion_r623206751



##########
File path: lib/go-tc/cdns.go
##########
@@ -102,11 +102,24 @@ type CDNNullable struct {
 	Name *string `json:"name" db:"name"`
 }
 
-// CDNSSLKeysResponse ...
+// CDNSSLKeysResponse is the structure of the Traffic Ops API's response to
+// requests made to its /cdns/name/{{name}}/sslkeys endpoint.
 type CDNSSLKeysResponse struct {
 	Response []CDNSSLKeys `json:"response"`
 }
 
+// CDNSSLKeysResponseV40 is the structure of the Traffic Ops API's response to
+// requests made to its /cdns/name/{{name}}/sslkeys endpoint in API version 4.0.
+type CDNSSLKeysResponseV40 struct {
+	Response []CDNSSLKeys `json:"response"`
+	Alerts

Review comment:
       Wouldn't that be a problem for old client versions?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org