[GitHub] [hive] deniskuzZ commented on a change in pull request #2086: HIVE-24900 Failed compaction does not cleanup the directories

[GitBox <gi...@apache.org>]

deniskuzZ commented on a change in pull request #2086:
URL: https://github.com/apache/hive/pull/2086#discussion_r596828645



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -523,6 +524,15 @@ protected Boolean findNextCompactionAndExecute(boolean computeStats) throws Inte
       final StatsUpdater su = computeStats ? StatsUpdater.init(ci, msc.findColumnsWithStats(
           CompactionInfo.compactionInfoToStruct(ci)), conf,
           runJobAsSelf(ci.runAs) ? ci.runAs : t.getOwner()) : null;
+      // result directory for compactor to write new files
+      Path resultDir = null;
+      if (ci.type == CompactionType.MAJOR) {

Review comment:
       Could this be simplified to just: 
   Path resultDir = QueryCompactor.Util.getCompactionResultDir(sd, tblValidWriteIds, conf, 
                ci.type == CompactionType.MAJOR, false, false, null);




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org