[jira] [Commented] (CLOUDSTACK-5810) addIpToNic: the owner of the secondary ip should be derived from vmInstance object, not from the caller account

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-5810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863775#comment-13863775 ] 

ASF subversion and git services commented on CLOUDSTACK-5810:
-------------------------------------------------------------

Commit b15431e57400023617fe494a3e93e1c4b65ee861 in branch refs/heads/master from [~alena1108]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b15431e ]

CLOUDSTACK-5810: addSecondaryIp to vm's nic - derive the ip owner from the vm instance account, not from the caller


> addIpToNic: the owner of the secondary ip should be derived from vmInstance object, not from the caller account
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-5810
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5810
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.3.0
>            Reporter: Alena Prokharchyk
>            Assignee: Alena Prokharchyk
>            Priority: Critical
>             Fix For: 4.4.0
>
>
> Steps to reproduce:
> ====================
> 1) Deploy a vm as a regular user account.
> 2) Login as admin, add secondary ip to the user's vm's nic.
> Bug: the secondary ip account owner is set to Admin account. This is wrong, as in CS we never let link objects belonging to diff accounts, unless its a public resource (template, network). In cases like this one, the owner info should be derived from the vm instance object.
> Jayapal, I will fix the API, and you have to fix the DB upgrade part. The fix should be: compare the sec ips accounts with the account of corresponding vms, and update nic_secondary_ips if account info is different. Should be done as a part of 43-44 upgrade.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)