You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Sun-GLiang (via GitHub)" <gi...@apache.org> on 2026/10/07 09:20:05 UTC

[PR] fix(ci): exercise production WorkHub browser click path [maka]

Sun-GLiang opened a new pull request, #5979:
URL: https://github.com/apache/maka/pull/5979

   ## Summary
   
   After Main closes, the WorkHub browser smoke manually dispatches a mouse down/up pair. That skips the target scrolling, hit testing and pointer positioning used by the production OpenCLI path.
   
   Use `withBrowserPage` for navigation and `page.click`, assert `click_method === 'cdp'`, and keep the observed “Clicked” effect assertion. Release the acquired browser session in `finally`.
   
   Split from #5969 following its scope review. This changes only the smoke script.
   
   ## Verification
   
   - Root build, typecheck, lint, format and desktop/UI Knip checks pass locally on Node 24.
   - The native smoke was attempted on macOS. Both this change and unchanged main (`3597abe8`) fail at the initial `docked: screen contains 0 browser pixels` assertion, before the modified click path. That local baseline failure prevents verification of native input here; the Linux/Xvfb CI smoke remains required.
   
   ## AI use
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: Codex (GPT-6) authored the smoke change and this description. The commit retains `Generated-by: Codex (GPT-6)`.
   
   ## Checklist
   
   - [x] Existing native-input and observed-click assertions are retained
   - [x] Build, lint, format and typecheck pass locally
   - [ ] Native smoke passes on the Linux/Xvfb CI environment
   
   Does this PR entail a change in behavior?
   
   - [ ] Yes
   - [x] No — smoke coverage and teardown only
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(ci): exercise production WorkHub browser click path [maka]

Posted by "Sun-GLiang (via GitHub)" <gi...@apache.org>.
Sun-GLiang merged PR #5979:
URL: https://github.com/apache/maka/pull/5979


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org