You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2012/07/13 02:59:24 UTC
svn commit: r1361026 - in /hbase/trunk/hbase-server/src/main:
jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon
java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
Author: apurtell
Date: Fri Jul 13 00:59:24 2012
New Revision: 1361026
URL: http://svn.apache.org/viewvc?rev=1361026&view=rev
Log:
HBASE-6377. HBASE-5533 metrics miss all operations submitted via MultiAction
Committed 6377-trunk-remove-get-put-delete-histograms.patch
Modified:
hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon
hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
Modified: hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon?rev=1361026&r1=1361025&r2=1361026&view=diff
==============================================================================
--- hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon (original)
+++ hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon Fri Jul 13 00:59:24 2012
@@ -219,9 +219,6 @@ java.lang.management.ManagementFactory;
</tr>
- <& histogramRow; op ="Get"; histo = metrics.getLatencies &>
- <& histogramRow; op ="Put"; histo = metrics.putLatencies &>
- <& histogramRow; op ="Delete"; histo = metrics.deleteLatencies &>
<& histogramRow; op ="FS Read"; histo = metrics.fsReadLatencyHistogram &>
<& histogramRow; op ="FS PRead"; histo = metrics.fsPreadLatencyHistogram &>
<& histogramRow; op ="FS Write"; histo = metrics.fsWriteLatencyHistogram &>
Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java?rev=1361026&r1=1361025&r2=1361026&view=diff
==============================================================================
--- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java (original)
+++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java Fri Jul 13 00:59:24 2012
@@ -133,25 +133,6 @@ public class RegionServerMetrics impleme
/** Block hit caching ratio for past N periods */
public final MetricsIntValue blockCacheHitCachingRatioPastNPeriods = new MetricsIntValue("blockCacheHitCachingRatioPastNPeriods", registry);
- /**
- * a latency histogram on 'get' requests
- */
- public final MetricsHistogram getLatencies =
- new MetricsHistogram("getRequestLatency", registry);
-
- /**
- * a latency histogram on 'delete' requests
- */
- public final MetricsHistogram deleteLatencies =
- new MetricsHistogram("deleteRequestLatency", registry);
-
- /**
- * a latency histogram on 'put' requests
- */
- public final MetricsHistogram putLatencies =
- new MetricsHistogram("putRequestLatency", registry);
-
-
/*
* Count of requests to the regionservers since last call to metrics update
*/
@@ -398,10 +379,6 @@ public class RegionServerMetrics impleme
this.blockCacheHitRatioPastNPeriods.pushMetric(this.metricsRecord);
this.blockCacheHitCachingRatioPastNPeriods.pushMetric(this.metricsRecord);
- this.putLatencies.pushMetric(this.metricsRecord);
- this.deleteLatencies.pushMetric(this.metricsRecord);
- this.getLatencies.pushMetric(this.metricsRecord);
-
// Mix in HFile and HLog metrics
// Be careful. Here is code for MTVR from up in hadoop:
// public synchronized void inc(final int numOps, final long time) {
@@ -589,9 +566,6 @@ public class RegionServerMetrics impleme
Long.valueOf(this.hdfsBlocksLocalityIndex.get()));
sb = Strings.appendKeyValue(sb, "slowHLogAppendCount",
Long.valueOf(this.slowHLogAppendCount.get()));
- sb = appendHistogram(sb, this.deleteLatencies);
- sb = appendHistogram(sb, this.getLatencies);
- sb = appendHistogram(sb, this.putLatencies);
sb = appendHistogram(sb, this.fsReadLatencyHistogram);
sb = appendHistogram(sb, this.fsPreadLatencyHistogram);
sb = appendHistogram(sb, this.fsWriteLatencyHistogram);