You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by ck...@apache.org on 2018/04/17 20:18:35 UTC
logging-log4j2 git commit: AbstractLogger.handleLogMessageException
uses parameterized logging
Repository: logging-log4j2
Updated Branches:
refs/heads/master a58e1d5cc -> 56d00d69f
AbstractLogger.handleLogMessageException uses parameterized logging
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/56d00d69
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/56d00d69
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/56d00d69
Branch: refs/heads/master
Commit: 56d00d69f4adb76318e45d1c64321d38f59f874c
Parents: a58e1d5
Author: Carter Kozak <ck...@apache.org>
Authored: Tue Apr 17 16:01:33 2018 -0400
Committer: Carter Kozak <ck...@apache.org>
Committed: Tue Apr 17 16:17:12 2018 -0400
----------------------------------------------------------------------
.../org/apache/logging/log4j/spi/AbstractLogger.java | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/56d00d69/log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java
----------------------------------------------------------------------
diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java b/log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java
index 5b6ac1a..6e67d5b 100644
--- a/log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java
+++ b/log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java
@@ -2180,17 +2180,8 @@ public abstract class AbstractLogger implements ExtendedLogger, Serializable {
if (exception instanceof LoggingException) {
throw (LoggingException) exception;
}
- final String format = msg.getFormat();
- final int formatLength = format == null ? 4 : format.length();
- final StringBuilder sb = new StringBuilder(formatLength + 100);
- sb.append(fqcn);
- sb.append(" caught ");
- sb.append(exception.getClass().getName());
- sb.append(" logging ");
- sb.append(msg.getClass().getSimpleName());
- sb.append(": ");
- sb.append(format);
- StatusLogger.getLogger().warn(sb.toString(), exception);
+ StatusLogger.getLogger().warn("{} caught {} logging {}: {}", fqcn, exception.getClass().getName(),
+ msg.getClass().getSimpleName(), msg.getFormat(), exception);
}
@Override