[incubator-annotator] branch master updated: Remove the import/no-internal-modules lint rule

[ra...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

randall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-annotator.git


The following commit(s) were added to refs/heads/master by this push:
     new 2de1a07  Remove the import/no-internal-modules lint rule
2de1a07 is described below

commit 2de1a07d2fd6c88df5b1d814cf3508e3fbc15ebe
Author: Randall Leeds <ra...@apache.org>
AuthorDate: Sun Sep 20 01:46:12 2020 -0700

    Remove the import/no-internal-modules lint rule
    
    With Node.js adopting a standard for packages to declare their exports,
    this rule may not be useful anymore. It should be legal to import any
    valid export from a package.
    
    An open [issue] on eslint-plugin-import tracks this ecosystem feature
    and when that resolves there may be a better rule to enable.
    
    [issue]: https://github.com/benmosher/eslint-plugin-import/issues/1868
---
 .eslintrc.js | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/.eslintrc.js b/.eslintrc.js
index 4542721..9c9e734 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -18,7 +18,6 @@
  * under the License.
  */
 
-const path = require('path');
 const babel = require('@babel/core');
 
 // Use the root babel.config.js for module resolution.
@@ -44,7 +43,6 @@ module.exports = {
     'import/newline-after-import': 'error',
     'import/no-absolute-path': 'error',
     'import/no-default-export': 'error',
-    'import/no-internal-modules': 'error',
     'import/order': [
       'error',
       {
@@ -141,12 +139,6 @@ module.exports = {
         assert: true,
       },
       rules: {
-        'import/no-internal-modules': [
-          'error',
-          {
-            allow: [path.resolve(__dirname, './packages/*/src/**')],
-          },
-        ],
         'import/no-relative-parent-imports': 'off',
       },
     },