You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2023/06/20 17:53:55 UTC
[GitHub] [superset] rusackas opened a new pull request, #24462: updating images and markdown
rusackas opened a new pull request, #24462:
URL: https://github.com/apache/superset/pull/24462
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
Updating some outdated images (though not all of them 😅) and corresponding markdown
Hat tip to @kikobarr
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
<img width="753" alt="image" src="https://github.com/apache/superset/assets/812905/79249ba2-21c3-4a9b-81c6-3646f7fb9b70">
After:
<img width="760" alt="image" src="https://github.com/apache/superset/assets/812905/798debd7-0cdc-4acd-b106-a445da51ec6b">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
Ran the Docusarus site locally - you can too!
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24462: updating images and markdown
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24462:
URL: https://github.com/apache/superset/pull/24462#issuecomment-1599264115
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24462?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24462](https://app.codecov.io/gh/apache/superset/pull/24462?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3c99814) into [master](https://app.codecov.io/gh/apache/superset/commit/fdef9cbc96c3aeb1445e55632a6e6baccade16b4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (fdef9cb) will **decrease** coverage by `10.79%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #24462 +/- ##
===========================================
- Coverage 68.94% 58.15% -10.79%
===========================================
Files 1901 1901
Lines 73974 73974
Branches 8119 8119
===========================================
- Hits 50999 43020 -7979
- Misses 20864 28843 +7979
Partials 2111 2111
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `54.17% <ø> (+0.27%)` | :arrow_up: |
| mysql | `?` | |
| presto | `?` | |
| python | `60.86% <ø> (-22.46%)` | :arrow_down: |
| unit | `54.60% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 296 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24462/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #24462: docs: updating images and markdown
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #24462:
URL: https://github.com/apache/superset/pull/24462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org