You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/18 08:04:17 UTC

[GitHub] [doris] Kikyou1997 commented on a diff in pull request #10240: [Refactor](nereids) Abstract interface of statistics framework for new optimizer reuse

Kikyou1997 commented on code in PR #10240:
URL: https://github.com/apache/doris/pull/10240#discussion_r900717225


##########
fe/fe-core/src/main/java/org/apache/doris/planner/PlanNode.java:
##########
@@ -353,6 +327,11 @@ public List<Expr> getConjuncts() {
         return conjuncts;
     }
 
+    @Override
+    public List<? extends PlanStats> getChildrenStats() {
+        return children;

Review Comment:
   It chould get StatsDeriveResult by `PlanStats::getStatsDeriveResult`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org