[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…

[GitBox <gi...@apache.org>]

Spaceman1984 commented on a change in pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#discussion_r665927710



##########
File path: setup/bindir/cloud-setup-databases.in
##########
@@ -248,21 +252,21 @@ for full help
             p = os.path.join(self.dbFilesPath, 'server-setup.sql')
             text = open(p).read()
             self.info("Applying %s"%p)
-            self.runMysql(text, p, True)
+            self.runMysql(text, p, self.rootuser != None)
             self.info(None, True)
 
         for f in ["templates"]:
             p = os.path.join(self.dbFilesPath,"%s.sql"%f)
             text = open(p).read()
             self.info("Applying %s"%p)
-            self.runMysql(text, p, True)
+            self.runMysql(text, p, self.rootuser != None)

Review comment:
       The database creation, and user creation is skipped and the root user and password is used.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org