You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by "jdaugherty (via GitHub)" <gi...@apache.org> on 2025/05/03 02:11:11 UTC
[PR] reproducible builds - groovydoc 4, profile fixes, and ensuring gradle projects build docs [grails-core]
jdaugherty opened a new pull request, #14710:
URL: https://github.com/apache/grails-core/pull/14710
https://github.com/apache/grails-core/issues/14679
* uses groovydoc 4
* fixes the profiles to be reproducible
* ensures source & javadoc jars are built as part of the test script
* ensures the gradle projects uses groovydoc instead of javadoc to generate documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] reproducible builds - groovydoc 4, profile fixes, and ensuring gradle projects build docs [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #14710:
URL: https://github.com/apache/grails-core/pull/14710#issuecomment-2858969107
I have removed the bom changes so that only the build uses the snapshot build for documentation generation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] reproducible builds - groovydoc 4, profile fixes, and ensuring gradle projects build docs [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #14710:
URL: https://github.com/apache/grails-core/pull/14710#issuecomment-2848452527
I'm going to hold off on merging this for a bit. Paul is continuing to investigate the groovy ordering issues and I want to use this PR to easily test the snapshot changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] reproducible builds - groovydoc 4, profile fixes, and ensuring gradle projects build docs [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on code in PR #14710:
URL: https://github.com/apache/grails-core/pull/14710#discussion_r2072288113
##########
grails-bootstrap/build.gradle:
##########
@@ -38,12 +38,10 @@ dependencies {
exclude group: 'org.codehaus.groovy'
}
- // we have to continue to compile with groovy 3 only because of grails-shell
- // the grails-shell will run under gradle and thus this must remain compatible
- compileOnly "org.codehaus.groovy:groovy:$GroovySystem.version"
- compileOnly "org.codehaus.groovy:groovy-templates:$GroovySystem.version"
- compileOnly "org.codehaus.groovy:groovy-xml:$GroovySystem.version"
- compileOnly "org.codehaus.groovy:groovy-ant:$GroovySystem.version"
+ compileOnly 'org.apache.groovy:groovy'
Review Comment:
I spoke to @jamesfredley about this change. Since bootstrap is included by both gorm, and core, we should be compiling with 4. We'll know if it breaks b/c shell still uses 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] reproducible builds - groovydoc 4, profile fixes, and ensuring gradle projects build docs [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty merged PR #14710:
URL: https://github.com/apache/grails-core/pull/14710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org