You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/06/30 22:45:38 UTC

[Impala-ASF-CR] IMPALA-11398: Update flake8 in Gerrit review (part 2)

Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18685


Change subject: IMPALA-11398: Update flake8 in Gerrit review (part 2)
......................................................................

IMPALA-11398: Update flake8 in Gerrit review (part 2)

Updates the flake8 version used in critique-gerrit-review.py to 3.9.2 so
it recognizes the indent-size property.

Change-Id: Iae62749117ce1bf3d895b4ee4d024ffa8126ce04
---
M bin/jenkins/critique-gerrit-review.py
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/18685/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae62749117ce1bf3d895b4ee4d024ffa8126ce04
Gerrit-Change-Number: 18685
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-11398: Update flake8 in Gerrit review (part 2)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18685 )

Change subject: IMPALA-11398: Update flake8 in Gerrit review (part 2)
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae62749117ce1bf3d895b4ee4d024ffa8126ce04
Gerrit-Change-Number: 18685
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Jul 2022 12:59:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11398: Update flake8 in Gerrit review (part 2)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18685 )

Change subject: IMPALA-11398: Update flake8 in Gerrit review (part 2)
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae62749117ce1bf3d895b4ee4d024ffa8126ce04
Gerrit-Change-Number: 18685
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Jul 2022 04:26:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11398: Update flake8 in Gerrit review (part 2)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18685 )

Change subject: IMPALA-11398: Update flake8 in Gerrit review (part 2)
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8285/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae62749117ce1bf3d895b4ee4d024ffa8126ce04
Gerrit-Change-Number: 18685
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Jul 2022 04:26:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11398: Update flake8 in Gerrit review (part 2)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18685 )

Change subject: IMPALA-11398: Update flake8 in Gerrit review (part 2)
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae62749117ce1bf3d895b4ee4d024ffa8126ce04
Gerrit-Change-Number: 18685
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Jul 2022 17:42:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11398: Update flake8 in Gerrit review (part 2)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18685 )

Change subject: IMPALA-11398: Update flake8 in Gerrit review (part 2)
......................................................................

IMPALA-11398: Update flake8 in Gerrit review (part 2)

Updates the flake8 version used in critique-gerrit-review.py to 3.9.2 so
it recognizes the indent-size property.

Change-Id: Iae62749117ce1bf3d895b4ee4d024ffa8126ce04
Reviewed-on: http://gerrit.cloudera.org:8080/18685
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/jenkins/critique-gerrit-review.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae62749117ce1bf3d895b4ee4d024ffa8126ce04
Gerrit-Change-Number: 18685
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-11398: Update flake8 in Gerrit review (part 2)

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18685 )

Change subject: IMPALA-11398: Update flake8 in Gerrit review (part 2)
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae62749117ce1bf3d895b4ee4d024ffa8126ce04
Gerrit-Change-Number: 18685
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Jun 2022 22:52:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11398: Update flake8 in Gerrit review (part 2)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18685 )

Change subject: IMPALA-11398: Update flake8 in Gerrit review (part 2)
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10906/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae62749117ce1bf3d895b4ee4d024ffa8126ce04
Gerrit-Change-Number: 18685
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Jun 2022 23:00:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11398: Update flake8 in Gerrit review (part 2)

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18685 )

Change subject: IMPALA-11398: Update flake8 in Gerrit review (part 2)
......................................................................


Patch Set 1:

I think this will address all the false warnings in https://gerrit.cloudera.org/c/18684/, but not sure how to test it.


-- 
To view, visit http://gerrit.cloudera.org:8080/18685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae62749117ce1bf3d895b4ee4d024ffa8126ce04
Gerrit-Change-Number: 18685
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Jun 2022 22:48:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11398: Update flake8 in Gerrit review (part 2)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18685 )

Change subject: IMPALA-11398: Update flake8 in Gerrit review (part 2)
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8285/


-- 
To view, visit http://gerrit.cloudera.org:8080/18685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae62749117ce1bf3d895b4ee4d024ffa8126ce04
Gerrit-Change-Number: 18685
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Jul 2022 09:08:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11398: Update flake8 in Gerrit review (part 2)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18685 )

Change subject: IMPALA-11398: Update flake8 in Gerrit review (part 2)
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8287/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae62749117ce1bf3d895b4ee4d024ffa8126ce04
Gerrit-Change-Number: 18685
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Jul 2022 12:59:48 +0000
Gerrit-HasComments: No