Re: cvs commit: cocoon-2.1/src/blocks/jsp/java/org/apache/cocoon/components/jsp JSPEngineImplNamedDispatcherInclude.java JSPEngineImpl.java

[Vadim Gritsenko <va...@verizon.net>]

joerg@apache.org wrote:

>joerg       2003/07/12 06:30:02
>
>  --- JspGenerator.java	10 Jul 2003 23:38:04 -0000	1.3
>  +++ JspGenerator.java	12 Jul 2003 13:30:02 -0000	1.4
>  @@ -131,8 +131,6 @@
>               throw new ProcessingException("SAXException JspGenerator.generate()",e.getException());
>           } catch (IOException e) {
>               throw new ProcessingException("IOException JspGenerator.generate()",e);
>  -        } catch (ProcessingException e) {
>  -            throw e;
>  
>

This code avoids unnecessary wrapping of ProcessingException into one 
more ProcessingException. What was the reason to remove it? It took some 
time to add all those small pieces to avoid excessive exception wrapping...

Vadim

Re: cvs commit: cocoon-2.1/src/blocks/jsp/java/org/apache/cocoon/components/jsp JSPEngineImplNamedDispatcherInclude.java JSPEngineImpl.java

[Joerg Heinicke <jo...@gmx.de>]

Vadim Gritsenko wrote:
> joerg@apache.org wrote:
>
>>               throw new ProcessingException("SAXException 
>> JspGenerator.generate()",e.getException());
>>           } catch (IOException e) {
>>               throw new ProcessingException("IOException 
>> JspGenerator.generate()",e);
>>  -        } catch (ProcessingException e) {
>>  -            throw e;
>>  
>>
> 
> This code avoids unnecessary wrapping of ProcessingException into one 
> more ProcessingException. What was the reason to remove it? It took some 
> time to add all those small pieces to avoid excessive exception wrapping...
> 
> Vadim

Sorry, have been too fast here. I only saw the re-throw, which could be 
removed in general, but not if Exception is caught afterwards.

Joerg