You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2020/06/27 08:09:28 UTC
[GitHub] [incubator-tuweni] atoulme opened a new pull request #98: Gas tests
atoulme opened a new pull request #98:
URL: https://github.com/apache/incubator-tuweni/pull/98
<!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
<!-- https://github.com/apache/incubator-tuweni/blob/master/CONTRIBUTING.md -->
## PR description
Add more tests to cover the Gas class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #98: Gas tests
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #98:
URL: https://github.com/apache/incubator-tuweni/pull/98#issuecomment-650521864
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/98?src=pr&el=h1) Report
> Merging [#98](https://codecov.io/gh/apache/incubator-tuweni/pull/98?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/073beaf85c969587ff0bed88bb61d764077c59c1&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/98?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #98 +/- ##
============================================
+ Coverage 58.50% 58.54% +0.04%
- Complexity 3922 3928 +6
============================================
Files 392 392
Lines 19969 19969
Branches 2421 2421
============================================
+ Hits 11682 11691 +9
+ Misses 7041 7032 -9
Partials 1246 1246
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| #integration | `54.91% <ø> (+0.03%)` | `565.00 <ø> (+1.00)` | |
| #unit | `52.33% <ø> (+0.04%)` | `3649.00 <ø> (+6.00)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/98?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/tuweni/gossip/LoggingPeerRepository.java](https://codecov.io/gh/apache/incubator-tuweni/pull/98/diff?src=pr&el=tree#diff-Z29zc2lwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvZ29zc2lwL0xvZ2dpbmdQZWVyUmVwb3NpdG9yeS5qYXZh) | `64.28% <0.00%> (-3.58%)` | `7.00% <0.00%> (-1.00%)` | |
| [...e/tuweni/devp2p/v5/internal/DefaultUdpConnector.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/98/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvaW50ZXJuYWwvRGVmYXVsdFVkcENvbm5lY3Rvci5rdA==) | `82.20% <0.00%> (ø)` | `31.00% <0.00%> (+1.00%)` | |
| [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/98/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `52.98% <0.00%> (+0.22%)` | `0.00% <0.00%> (ø%)` | |
| [...ain/java/org/apache/tuweni/units/ethereum/Gas.java](https://codecov.io/gh/apache/incubator-tuweni/pull/98/diff?src=pr&el=tree#diff-dW5pdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS91bml0cy9ldGhlcmV1bS9HYXMuamF2YQ==) | `68.29% <0.00%> (+21.95%)` | `16.00% <0.00%> (+6.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/98?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/98?src=pr&el=footer). Last update [073beaf...9d1a447](https://codecov.io/gh/apache/incubator-tuweni/pull/98?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #98: Gas tests
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #98:
URL: https://github.com/apache/incubator-tuweni/pull/98#issuecomment-650521864
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/98?src=pr&el=h1) Report
> Merging [#98](https://codecov.io/gh/apache/incubator-tuweni/pull/98?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/073beaf85c969587ff0bed88bb61d764077c59c1&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/98?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #98 +/- ##
============================================
+ Coverage 58.50% 58.54% +0.04%
- Complexity 3922 3928 +6
============================================
Files 392 392
Lines 19969 19969
Branches 2421 2421
============================================
+ Hits 11682 11691 +9
+ Misses 7041 7032 -9
Partials 1246 1246
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| #integration | `54.88% <ø> (ø)` | `564.00 <ø> (ø)` | |
| #unit | `52.33% <ø> (+0.04%)` | `3649.00 <ø> (+6.00)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/98?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/tuweni/gossip/LoggingPeerRepository.java](https://codecov.io/gh/apache/incubator-tuweni/pull/98/diff?src=pr&el=tree#diff-Z29zc2lwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvZ29zc2lwL0xvZ2dpbmdQZWVyUmVwb3NpdG9yeS5qYXZh) | `64.28% <0.00%> (-3.58%)` | `7.00% <0.00%> (-1.00%)` | |
| [...e/tuweni/devp2p/v5/internal/DefaultUdpConnector.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/98/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvaW50ZXJuYWwvRGVmYXVsdFVkcENvbm5lY3Rvci5rdA==) | `82.20% <0.00%> (ø)` | `31.00% <0.00%> (+1.00%)` | |
| [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/98/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `52.98% <0.00%> (+0.22%)` | `0.00% <0.00%> (ø%)` | |
| [...ain/java/org/apache/tuweni/units/ethereum/Gas.java](https://codecov.io/gh/apache/incubator-tuweni/pull/98/diff?src=pr&el=tree#diff-dW5pdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS91bml0cy9ldGhlcmV1bS9HYXMuamF2YQ==) | `68.29% <0.00%> (+21.95%)` | `16.00% <0.00%> (+6.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/98?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/98?src=pr&el=footer). Last update [073beaf...9d1a447](https://codecov.io/gh/apache/incubator-tuweni/pull/98?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme merged pull request #98: Gas tests
Posted by GitBox <gi...@apache.org>.
atoulme merged pull request #98:
URL: https://github.com/apache/incubator-tuweni/pull/98
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #98: Gas tests
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #98:
URL: https://github.com/apache/incubator-tuweni/pull/98#issuecomment-650521864
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/98?src=pr&el=h1) Report
> Merging [#98](https://codecov.io/gh/apache/incubator-tuweni/pull/98?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/073beaf85c969587ff0bed88bb61d764077c59c1&el=desc) will **decrease** coverage by `3.61%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/98?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #98 +/- ##
============================================
- Coverage 58.50% 54.88% -3.62%
+ Complexity 3922 564 -3358
============================================
Files 392 132 -260
Lines 19969 5417 -14552
Branches 2421 582 -1839
============================================
- Hits 11682 2973 -8709
+ Misses 7041 2133 -4908
+ Partials 1246 311 -935
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| #integration | `54.88% <ø> (ø)` | `564.00 <ø> (ø)` | |
| #unit | `?` | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/98?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../kotlin/org/apache/tuweni/devp2p/v5/PacketCodec.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/98/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUGFja2V0Q29kZWMua3Q=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rg/apache/tuweni/devp2p/v5/packet/TicketMessage.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/98/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvcGFja2V0L1RpY2tldE1lc3NhZ2Uua3Q=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../apache/tuweni/devp2p/v5/packet/RegTopicMessage.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/98/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvcGFja2V0L1JlZ1RvcGljTWVzc2FnZS5rdA==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-7.00%)` | |
| [...ava/org/apache/tuweni/scuttlebutt/rpc/RPCFlag.java](https://codecov.io/gh/apache/incubator-tuweni/pull/98/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0ZsYWcuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pache/tuweni/devp2p/v5/packet/TopicQueryMessage.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/98/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvcGFja2V0L1RvcGljUXVlcnlNZXNzYWdlLmt0) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../tuweni/devp2p/v5/packet/RegConfirmationMessage.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/98/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvcGFja2V0L1JlZ0NvbmZpcm1hdGlvbk1lc3NhZ2Uua3Q=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...weni/scuttlebutt/handshake/HandshakeException.java](https://codecov.io/gh/apache/incubator-tuweni/pull/98/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtaGFuZHNoYWtlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvaGFuZHNoYWtlL0hhbmRzaGFrZUV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ebutt/handshake/SecureScuttlebuttStreamServer.java](https://codecov.io/gh/apache/incubator-tuweni/pull/98/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtaGFuZHNoYWtlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvaGFuZHNoYWtlL1NlY3VyZVNjdXR0bGVidXR0U3RyZWFtU2VydmVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...in/org/apache/tuweni/devp2p/v5/topic/TopicTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/98/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvdG9waWMvVG9waWNUYWJsZS5rdA==) | `15.15% <0.00%> (-69.70%)` | `2.00% <0.00%> (-12.00%)` | |
| [...p/src/main/kotlin/org/apache/tuweni/devp2p/Node.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/98/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvTm9kZS5rdA==) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [301 more](https://codecov.io/gh/apache/incubator-tuweni/pull/98/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/98?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/98?src=pr&el=footer). Last update [073beaf...9d1a447](https://codecov.io/gh/apache/incubator-tuweni/pull/98?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org