[GitHub] [airflow] pateash commented on a change in pull request #16821: Add more filter options to list_keys of S3Hook

[GitBox <gi...@apache.org>]

pateash commented on a change in pull request #16821:
URL: https://github.com/apache/airflow/pull/16821#discussion_r666683466



##########
File path: airflow/providers/amazon/aws/hooks/s3.py
##########
@@ -269,6 +270,9 @@ def list_keys(
         delimiter: Optional[str] = None,
         page_size: Optional[int] = None,
         max_items: Optional[int] = None,
+        start_after_key: Optional[str] = '',

Review comment:
       ```suggestion
           start_after_key: Optional[str] = None,
   ```

##########
File path: airflow/providers/amazon/aws/hooks/s3.py
##########
@@ -269,6 +270,9 @@ def list_keys(
         delimiter: Optional[str] = None,
         page_size: Optional[int] = None,
         max_items: Optional[int] = None,
+        start_after_key: Optional[str] = '',

Review comment:
       Completely agree with @dstandish,
   I have never seen a default string as literal '' in my experience in Airflow codebase.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org