You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cookiedough77 (via GitHub)" <gi...@apache.org> on 2025/09/29 23:37:41 UTC
[PR] Use unquoted for response fields [spark]
cookiedough77 opened a new pull request, #52483:
URL: https://github.com/apache/spark/pull/52483
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
This PR fixes the bug where quoted names were being set in the proto response fields for catalog, database, and identifier.
Changes include:
- Removing the use of quoteIdentifier when populating resolvedCatalog, resolvedDb, and resolvedId in the proto response.
- Updating the code to return the raw catalog, database, and identifier values from CatalystIdentifier instead.
- Adjusting unit tests in SparkDeclarativePipelinesServerSuite to validate that proto fields contain unquoted strings, even when names contain special characters like backticks.
### Why are the changes needed?
Quoted names are only required when constructing fully qualified string identifiers (e.g., `cat`.`db`.`table`). Proto messages keep catalog, database, and identifier as separate fields and should store the raw values. Returning quoted names in proto fields was a bug and could cause inconsistencies in client usage.
### Does this PR introduce _any_ user-facing change?
Yes. The proto responses for dataset and flow definitions will now return raw catalog, database, and identifier values instead of quoted versions. For example, a catalog named a`b will be returned as a\bin the proto field, not ``ab` .
### How was this patch tested?
Updated SparkDeclarativePipelinesServerSuite to verify that proto fields contain raw, unquoted names.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53593][SDP] Fix: Use unquoted for response fields [spark]
Posted by "sryza (via GitHub)" <gi...@apache.org>.
sryza closed pull request #52483: [SPARK-53593][SDP] Fix: Use unquoted for response fields
URL: https://github.com/apache/spark/pull/52483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org