You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by sr...@apache.org on 2018/07/05 21:35:20 UTC
spark git commit: [SPARK-24694][K8S] Pass all app args to integration
tests
Repository: spark
Updated Branches:
refs/heads/master 33952cfa8 -> e71e93aaa
[SPARK-24694][K8S] Pass all app args to integration tests
## What changes were proposed in this pull request?
- Allows to pass more than one app args to tests.
## How was this patch tested?
Manually tested it with a spark test that requires more than on app args.
Author: Stavros Kontopoulos <st...@lightbend.com>
Closes #21672 from skonto/fix_itsets-args.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/e71e93aa
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/e71e93aa
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/e71e93aa
Branch: refs/heads/master
Commit: e71e93aaaa0d26301e10d3dc65f4db298424e99a
Parents: 33952cf
Author: Stavros Kontopoulos <st...@lightbend.com>
Authored: Thu Jul 5 16:35:16 2018 -0500
Committer: Sean Owen <sr...@gmail.com>
Committed: Thu Jul 5 16:35:16 2018 -0500
----------------------------------------------------------------------
.../deploy/k8s/integrationtest/KubernetesTestComponents.scala | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/e71e93aa/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesTestComponents.scala
----------------------------------------------------------------------
diff --git a/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesTestComponents.scala b/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesTestComponents.scala
index 4872714..b2471e5 100644
--- a/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesTestComponents.scala
+++ b/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesTestComponents.scala
@@ -105,16 +105,13 @@ private[spark] object SparkAppLauncher extends Logging {
sparkHomeDir: Path): Unit = {
val sparkSubmitExecutable = sparkHomeDir.resolve(Paths.get("bin", "spark-submit"))
logInfo(s"Launching a spark app with arguments $appArguments and conf $appConf")
- val appArgsArray =
- if (appArguments.appArgs.length > 0) Array(appArguments.appArgs.mkString(" "))
- else Array[String]()
val commandLine = (Array(sparkSubmitExecutable.toFile.getAbsolutePath,
"--deploy-mode", "cluster",
"--class", appArguments.mainClass,
"--master", appConf.get("spark.master")
) ++ appConf.toStringArray :+
appArguments.mainAppResource) ++
- appArgsArray
+ appArguments.appArgs
ProcessUtils.executeProcess(commandLine, timeoutSecs)
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org