You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2017/07/06 08:13:25 UTC
Review Request 60679: LENS-1451: Enforcing valid fact tables doesn't
filter out segmentations
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60679/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1451
https://issues.apache.org/jira/browse/LENS-1451
Repository: lens
Description
-------
valid fact tables key is used to enforce which facts can be picked. Currently, this property still lets segmentations remain valid candidates and enforcing doesn't happen.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java be3b4749fd7780b83f9d0c7dbeb674dff284a1f4
Diff: https://reviews.apache.org/r/60679/diff/1/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 60679: LENS-1451: Enforcing valid fact tables
doesn't filter out segmentations
Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60679/#review179765
-----------------------------------------------------------
Ship it!
Ship It!
- Sushil Mohanty
On July 6, 2017, 8:13 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60679/
> -----------------------------------------------------------
>
> (Updated July 6, 2017, 8:13 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1451
> https://issues.apache.org/jira/browse/LENS-1451
>
>
> Repository: lens
>
>
> Description
> -------
>
> valid fact tables key is used to enforce which facts can be picked. Currently, this property still lets segmentations remain valid candidates and enforcing doesn't happen.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java be3b4749fd7780b83f9d0c7dbeb674dff284a1f4
>
>
> Diff: https://reviews.apache.org/r/60679/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>