You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/05/11 22:06:09 UTC

[kudu-CR] pprof: fix tmp filename path construction

Hello Dan Burkert,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3029

to review the following change.

Change subject: pprof: fix tmp filename path construction
......................................................................

pprof: fix tmp filename path construction

The pprof handler was trying to store the profile data in
/tmp/kudu_cpu_profile/<pid>.<rand>. The kudu_cpu_profile directory is unlikely
to exist, which makes the path handler fail.

This seems to have been an accidental regression in
d20b44704033d46be76ce4bfa55df09251b45520.

This restores the prior behavior of /tmp/kudu_cpu_profile.<pid>.<rand>

Change-Id: I555037cb2ee59ef3735e209816def23d8bed856b
---
M src/kudu/server/pprof-path-handlers.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/3029/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I555037cb2ee59ef3735e209816def23d8bed856b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>