Re: [PR] Add stream method to RemoteIO [airflow]

["Lee-W (via GitHub)" <gi...@apache.org>]

Lee-W commented on code in PR #54813:
URL: https://github.com/apache/airflow/pull/54813#discussion_r2485906433


##########
airflow-core/src/airflow/utils/log/file_task_handler.py:
##########
@@ -936,5 +935,10 @@ def _read_remote_logs(self, ti, try_number, metadata=None) -> LegacyLogResponse
         # This living here is not really a good plan, but it just about works for now.
         # Ideally we move all the read+combine logic in to TaskLogReader and out of the task handler.
         path = self._render_filename(ti, try_number)
+        if hasattr(remote_io, "stream") and (stream_method := getattr(remote_io, "stream")):

Review Comment:
   ```suggestion
           if (stream_method := getattr(remote_io, "stream", None)):
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org