[GitHub] [hadoop-ozone] captainzmc commented on issue #683: HDDS-3149. Make o3fs support set and get acl

[GitBox <gi...@apache.org>]

captainzmc commented on issue #683: HDDS-3149. Make o3fs support set and get acl
URL: https://github.com/apache/hadoop-ozone/pull/683#issuecomment-607856419
 
 
   > @captainzmc Thanks for working on this! The changes look good to me. Please find my comments below.
   > 
   > 1. There are few test failures. Can you please look at that?
   > 2. Can you also add a unit test for the added apis in TestOzoneFileSystem?
   > 3. There are other acl based apis in FileSystem class. Can you also create jiras for those?
   
   Hi @lokeshj1703 Very thanks for your review and you suggestion is good.
   1. By reopen this PR, run the UT, the second run was successful. Look at the previous error, should be caused by other places. Maybe there need another JIRA to fix ut.
   2. I will consider increase ut in TestOzoneFileSystem. 
   3. We've tested the BaseOzoneFile API before and found a lot of unsupported content([HDDS-3048](https://issues.apache.org/jira/browse/HDDS-3048)). Currently, we have plans to improve this part of the content(such as removeAcl and so on).
   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org