You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2023/05/09 16:17:03 UTC

[GitHub] [arrow] pitrou commented on a diff in pull request #35471: GH-35176: [C++] Add support for disabling threading for emscripten

pitrou commented on code in PR #35471:
URL: https://github.com/apache/arrow/pull/35471#discussion_r1188841937


##########
.github/workflows/cpp.yml:
##########
@@ -57,11 +57,19 @@ jobs:
     name: ${{ matrix.title }}
     runs-on: ${{ matrix.runs-on }}
     if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
-    timeout-minutes: 75
+    timeout-minutes: 120
     strategy:
       fail-fast: false
       matrix:
         include:
+          - arch: amd64
+            clang-tools: "14"
+            image: ubuntu-cpp
+            llvm: "14"
+            runs-on: ubuntu-latest
+            title: AMD64 ubuntu-cpp no threads
+            ubuntu: "22.04"
+            enable_threading: "OFF"

Review Comment:
   I'm not convinced this should be part of the PR-based CI jobs. We can instead define a nightly build, which will stress our CI resources less. Perhaps @kou can help here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org