You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/06/05 09:32:37 UTC
[GitHub] [logging-log4j2] arturobernalg opened a new pull request #514: Java 8 Improvements:
arturobernalg opened a new pull request #514:
URL: https://github.com/apache/logging-log4j2/pull/514
Since log4j supports jdk versions > 8 the idea is to use Lambda's and method references.
* Replaced Anonymous type with method reference
* Replace Lambda with method reference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] arturobernalg commented on pull request #514: Java 8 Improvements:
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #514:
URL: https://github.com/apache/logging-log4j2/pull/514#issuecomment-867740270
> @rgoers, I see that you have already approved this PR, yet did not merge it. Later on, @arturobernalg force-pushed new changes. In order to avoid double work, I will appreciate if you can merge it right away.
Hi,
Just was a rebase from master
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy merged pull request #514: Java 8 Improvements:
Posted by GitBox <gi...@apache.org>.
vy merged pull request #514:
URL: https://github.com/apache/logging-log4j2/pull/514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] arturobernalg commented on pull request #514: Java 8 Improvements:
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #514:
URL: https://github.com/apache/logging-log4j2/pull/514#issuecomment-869375875
Sorry for the mess guys @vy @jvz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy commented on pull request #514: Java 8 Improvements:
Posted by GitBox <gi...@apache.org>.
vy commented on pull request #514:
URL: https://github.com/apache/logging-log4j2/pull/514#issuecomment-867733647
@rgoers, I see that you have already approved this PR, yet did not merge it. Later on, @arturobernalg force-pushed new changes. In order to avoid double work, I will appreciate if you can merge it right away.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] jvz commented on pull request #514: Java 8 Improvements:
Posted by GitBox <gi...@apache.org>.
jvz commented on pull request #514:
URL: https://github.com/apache/logging-log4j2/pull/514#issuecomment-869065572
@vy the cherry pick to master here also broke the build, but I fixed that one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy commented on pull request #514: Java 8 Improvements:
Posted by GitBox <gi...@apache.org>.
vy commented on pull request #514:
URL: https://github.com/apache/logging-log4j2/pull/514#issuecomment-869214104
Apologies for the mess and thanks so much @jvz!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org