You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/18 09:49:10 UTC

[GitHub] [incubator-shardingsphere] tuohai666 opened a new pull request #4353: #4255, use CAPI in stmt mode return incorrect response

tuohai666 opened a new pull request #4353: #4255, use CAPI in stmt mode return incorrect response
URL: https://github.com/apache/incubator-shardingsphere/pull/4353
 
 
   Fixes #4255.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4353: #4255, use CAPI in stmt mode return incorrect response

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #4353: #4255, use CAPI in stmt mode return incorrect response
URL: https://github.com/apache/incubator-shardingsphere/pull/4353#discussion_r380703126
 
 

 ##########
 File path: sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java
 ##########
 @@ -59,11 +55,9 @@ public MySQLComStmtPrepareExecutor(final MySQLComStmtPreparePacket packet, final
         SQLStatement sqlStatement = logicSchema.getParseEngine().parse(packet.getSql(), true);
         int parametersCount = sqlStatement.getParametersCount();
         result.add(new MySQLComStmtPrepareOKPacket(++currentSequenceId, PREPARED_STATEMENT_REGISTRY.register(packet.getSql(), parametersCount), getNumColumns(), parametersCount, 0));
-        TablesContext tablesContext = new TablesContext(sqlStatement);
         for (int i = 0; i < parametersCount; i++) {
             // TODO add column name
-            result.add(new MySQLColumnDefinition41Packet(++currentSequenceId, schemaName,
-                    tablesContext.isSingleTable() ? tablesContext.getSingleTableName() : "", "", "", "", 100, MySQLColumnType.MYSQL_TYPE_VARCHAR, 0));
+            result.add(new MySQLColumnDefinition41Packet(++currentSequenceId, "", "", "", "?", "", 0, MySQLColumnType.MYSQL_TYPE_VAR_STRING, 0));
 
 Review comment:
   We need to explain hard code with empty string

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response
URL: https://github.com/apache/incubator-shardingsphere/pull/4353#issuecomment-587393669
 
 
   ## Pull Request Test Coverage Report for [Build 1795](https://coveralls.io/builds/28795632)
   
   * **6** of **7**   **(85.71%)**  changed or added relevant lines in **2** files are covered.
   * **14** unchanged lines in **3** files lost coverage.
   * Overall coverage increased (+**0.003%**) to **57.637%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28795632/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L60) | 0 | 1 | 0.0%
   <!-- | **Total:** | **6** | **7** | **85.71%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28795632/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L46) | 2 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowIndexStatement.java](https://coveralls.io/builds/28795632/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowIndexStatement.java#L33) | 2 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDALVisitor.java](https://coveralls.io/builds/28795632/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDALVisitor.java#L137) | 10 | 0% |
   <!-- | **Total:** | **14** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28795632/badge)](https://coveralls.io/builds/28795632) |
   | :-- | --: |
   | Change from base [Build 875](https://coveralls.io/builds/28793443): |  0.003% |
   | Covered Lines: | 11087 |
   | Relevant Lines: | 19236 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tuohai666 commented on a change in pull request #4353: #4255, use CAPI in stmt mode return incorrect response

Posted by GitBox <gi...@apache.org>.
tuohai666 commented on a change in pull request #4353: #4255, use CAPI in stmt mode return incorrect response
URL: https://github.com/apache/incubator-shardingsphere/pull/4353#discussion_r380714127
 
 

 ##########
 File path: sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java
 ##########
 @@ -59,11 +55,9 @@ public MySQLComStmtPrepareExecutor(final MySQLComStmtPreparePacket packet, final
         SQLStatement sqlStatement = logicSchema.getParseEngine().parse(packet.getSql(), true);
         int parametersCount = sqlStatement.getParametersCount();
         result.add(new MySQLComStmtPrepareOKPacket(++currentSequenceId, PREPARED_STATEMENT_REGISTRY.register(packet.getSql(), parametersCount), getNumColumns(), parametersCount, 0));
-        TablesContext tablesContext = new TablesContext(sqlStatement);
         for (int i = 0; i < parametersCount; i++) {
             // TODO add column name
-            result.add(new MySQLColumnDefinition41Packet(++currentSequenceId, schemaName,
-                    tablesContext.isSingleTable() ? tablesContext.getSingleTableName() : "", "", "", "", 100, MySQLColumnType.MYSQL_TYPE_VARCHAR, 0));
+            result.add(new MySQLColumnDefinition41Packet(++currentSequenceId, "", "", "", "?", "", 0, MySQLColumnType.MYSQL_TYPE_VAR_STRING, 0));
 
 Review comment:
   OK. I'll add this in the reference issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4353: #4255, use CAPI in stmt mode return incorrect response

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4353: #4255, use CAPI in stmt mode return incorrect response
URL: https://github.com/apache/incubator-shardingsphere/pull/4353#issuecomment-587393669
 
 
   ## Pull Request Test Coverage Report for [Build 1788](https://coveralls.io/builds/28794032)
   
   * **6** of **7**   **(85.71%)**  changed or added relevant lines in **2** files are covered.
   * **4** unchanged lines in **1** file lost coverage.
   * Overall coverage increased (+**0.008%**) to **57.642%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28794032/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L62) | 0 | 1 | 0.0%
   <!-- | **Total:** | **6** | **7** | **85.71%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28794032/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L53) | 4 | 0% |
   <!-- | **Total:** | **4** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28794032/badge)](https://coveralls.io/builds/28794032) |
   | :-- | --: |
   | Change from base [Build 875](https://coveralls.io/builds/28793443): |  0.008% |
   | Covered Lines: | 11088 |
   | Relevant Lines: | 19236 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4353: #4255, use CAPI in stmt mode return incorrect response

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4353: #4255, use CAPI in stmt mode return incorrect response
URL: https://github.com/apache/incubator-shardingsphere/pull/4353
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response
URL: https://github.com/apache/incubator-shardingsphere/pull/4353#issuecomment-587393669
 
 
   ## Pull Request Test Coverage Report for [Build 9628](https://coveralls.io/builds/28795809)
   
   * **6** of **7**   **(85.71%)**  changed or added relevant lines in **2** files are covered.
   * **17** unchanged lines in **4** files lost coverage.
   * Overall coverage decreased (**-0.002%**) to **57.632%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28795809/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L60) | 0 | 1 | 0.0%
   <!-- | **Total:** | **6** | **7** | **85.71%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28795809/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L46) | 2 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowIndexStatement.java](https://coveralls.io/builds/28795809/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowIndexStatement.java#L33) | 2 | 0% |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28795809/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDALVisitor.java](https://coveralls.io/builds/28795809/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDALVisitor.java#L137) | 10 | 0% |
   <!-- | **Total:** | **17** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28795809/badge)](https://coveralls.io/builds/28795809) |
   | :-- | --: |
   | Change from base [Build 875](https://coveralls.io/builds/28793443): |  -0.002% |
   | Covered Lines: | 11086 |
   | Relevant Lines: | 19236 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response
URL: https://github.com/apache/incubator-shardingsphere/pull/4353#issuecomment-587393669
 
 
   ## Pull Request Test Coverage Report for [Build 1800](https://coveralls.io/builds/28797403)
   
   * **6** of **7**   **(85.71%)**  changed or added relevant lines in **2** files are covered.
   * **109** unchanged lines in **6** files lost coverage.
   * Overall coverage decreased (**-0.02%**) to **57.615%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28797403/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L60) | 0 | 1 | 0.0%
   <!-- | **Total:** | **6** | **7** | **85.71%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28797403/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L46) | 2 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowIndexStatement.java](https://coveralls.io/builds/28797403/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowIndexStatement.java#L33) | 2 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/SelectStatement.java](https://coveralls.io/builds/28797403/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FSelectStatement.java#L61) | 5 | 28.57% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDALVisitor.java](https://coveralls.io/builds/28797403/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDALVisitor.java#L137) | 10 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/28797403/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L281) | 44 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDMLVisitor.java](https://coveralls.io/builds/28797403/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDMLVisitor.java#L314) | 46 | 0% |
   <!-- | **Total:** | **109** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28797403/badge)](https://coveralls.io/builds/28797403) |
   | :-- | --: |
   | Change from base [Build 875](https://coveralls.io/builds/28793443): |  -0.02% |
   | Covered Lines: | 11088 |
   | Relevant Lines: | 19245 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response
URL: https://github.com/apache/incubator-shardingsphere/pull/4353#issuecomment-587393669
 
 
   ## Pull Request Test Coverage Report for [Build 1803](https://coveralls.io/builds/28801172)
   
   * **6** of **7**   **(85.71%)**  changed or added relevant lines in **2** files are covered.
   * **729** unchanged lines in **20** files lost coverage.
   * Overall coverage decreased (**-0.3%**) to **57.352%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28801172/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L60) | 0 | 1 | 0.0%
   <!-- | **Total:** | **6** | **7** | **85.71%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/TextProtocolBackendHandlerFactory.java](https://coveralls.io/builds/28801172/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Ftext%2FTextProtocolBackendHandlerFactory.java#L108) | 1 | 79.31% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/SQLSegmentsExtractorEngine.java](https://coveralls.io/builds/28801172/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2FSQLSegmentsExtractorEngine.java#L33) | 1 | 0% |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28801172/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L46) | 2 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowIndexStatement.java](https://coveralls.io/builds/28801172/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowIndexStatement.java#L33) | 2 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/SelectStatement.java](https://coveralls.io/builds/28801172/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FSelectStatement.java#L61) | 5 | 28.57% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerTCLVisitor.java](https://coveralls.io/builds/28801172/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerTCLVisitor.java#L38) | 8 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/SQLParseKernel.java](https://coveralls.io/builds/28801172/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2FSQLParseKernel.java#L45) | 10 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDALVisitor.java](https://coveralls.io/builds/28801172/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDALVisitor.java#L137) | 10 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/rule/registry/ParseRuleRegistry.java](https://coveralls.io/builds/28801172/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Frule%2Fregistry%2FParseRuleRegistry.java#L46) | 16 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/SQL92Visitor.java](https://coveralls.io/builds/28801172/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FSQL92Visitor.java#L334) | 31 | 0% |
   <!-- | **Total:** | **729** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28801172/badge)](https://coveralls.io/builds/28801172) |
   | :-- | --: |
   | Change from base [Build 875](https://coveralls.io/builds/28793443): |  -0.3% |
   | Covered Lines: | 11062 |
   | Relevant Lines: | 19288 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response
URL: https://github.com/apache/incubator-shardingsphere/pull/4353#issuecomment-587393669
 
 
   ## Pull Request Test Coverage Report for [Build 1802](https://coveralls.io/builds/28801203)
   
   * **8** of **9**   **(88.89%)**  changed or added relevant lines in **3** files are covered.
   * **730** unchanged lines in **21** files lost coverage.
   * Overall coverage decreased (**-0.3%**) to **57.347%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28801203/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L60) | 0 | 1 | 0.0%
   <!-- | **Total:** | **8** | **9** | **88.89%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/TextProtocolBackendHandlerFactory.java](https://coveralls.io/builds/28801203/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Ftext%2FTextProtocolBackendHandlerFactory.java#L108) | 1 | 79.31% |
   | [sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/mysql/packet/command/query/MySQLColumnDefinition41Packet.java](https://coveralls.io/builds/28801203/source?filename=sharding-proxy%2Fsharding-proxy-transport%2Fsharding-proxy-transport-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ftransport%2Fmysql%2Fpacket%2Fcommand%2Fquery%2FMySQLColumnDefinition41Packet.java#L37) | 1 | 98.0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/SQLSegmentsExtractorEngine.java](https://coveralls.io/builds/28801203/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2FSQLSegmentsExtractorEngine.java#L33) | 1 | 0% |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28801203/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L46) | 2 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowIndexStatement.java](https://coveralls.io/builds/28801203/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowIndexStatement.java#L33) | 2 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/SelectStatement.java](https://coveralls.io/builds/28801203/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FSelectStatement.java#L61) | 5 | 28.57% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerTCLVisitor.java](https://coveralls.io/builds/28801203/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerTCLVisitor.java#L38) | 8 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/SQLParseKernel.java](https://coveralls.io/builds/28801203/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2FSQLParseKernel.java#L45) | 10 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDALVisitor.java](https://coveralls.io/builds/28801203/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDALVisitor.java#L137) | 10 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/rule/registry/ParseRuleRegistry.java](https://coveralls.io/builds/28801203/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Frule%2Fregistry%2FParseRuleRegistry.java#L46) | 16 | 0% |
   <!-- | **Total:** | **730** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28801203/badge)](https://coveralls.io/builds/28801203) |
   | :-- | --: |
   | Change from base [Build 875](https://coveralls.io/builds/28793443): |  -0.3% |
   | Covered Lines: | 11061 |
   | Relevant Lines: | 19288 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4353: #4255, use CAPI in stmt mode return incorrect response

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4353: #4255, use CAPI in stmt mode return incorrect response
URL: https://github.com/apache/incubator-shardingsphere/pull/4353#issuecomment-587416603
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4353?src=pr&el=h1) Report
   > Merging [#4353](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4353?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/f26a0c22bc1265c4747ca77abc3969faaf44f751?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `85.71%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4353/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4353?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4353      +/-   ##
   ============================================
   + Coverage     54.16%   54.16%   +<.01%     
     Complexity      352      352              
   ============================================
     Files          1046     1046              
     Lines         19237    19236       -1     
     Branches       3536     3535       -1     
   ============================================
     Hits          10419    10419              
   + Misses         8161     8160       -1     
     Partials        657      657
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4353?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ry/binary/prepare/MySQLComStmtPrepareExecutor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4353/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktZnJvbnRlbmQvc2hhcmRpbmctcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5ncHJveHkvZnJvbnRlbmQvbXlzcWwvY29tbWFuZC9xdWVyeS9iaW5hcnkvcHJlcGFyZS9NeVNRTENvbVN0bXRQcmVwYXJlRXhlY3V0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...roxy/transport/mysql/constant/MySQLColumnType.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4353/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktdHJhbnNwb3J0L3NoYXJkaW5nLXByb3h5LXRyYW5zcG9ydC1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS90cmFuc3BvcnQvbXlzcWwvY29uc3RhbnQvTXlTUUxDb2x1bW5UeXBlLmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...phere/sql/parser/visitor/impl/MySQLDALVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4353/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvaW1wbC9NeVNRTERBTFZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...tatement/dal/dialect/mysql/ShowIndexStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4353/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2RhbC9kaWFsZWN0L215c3FsL1Nob3dJbmRleFN0YXRlbWVudC5qYXZh) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4353?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4353?src=pr&el=footer). Last update [f26a0c2...129495c](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response
URL: https://github.com/apache/incubator-shardingsphere/pull/4353#issuecomment-587393669
 
 
   ## Pull Request Test Coverage Report for [Build 1794](https://coveralls.io/builds/28795440)
   
   * **6** of **7**   **(85.71%)**  changed or added relevant lines in **2** files are covered.
   * **14** unchanged lines in **3** files lost coverage.
   * Overall coverage increased (+**0.003%**) to **57.637%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28795440/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L60) | 0 | 1 | 0.0%
   <!-- | **Total:** | **6** | **7** | **85.71%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28795440/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L46) | 2 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowIndexStatement.java](https://coveralls.io/builds/28795440/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowIndexStatement.java#L33) | 2 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDALVisitor.java](https://coveralls.io/builds/28795440/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDALVisitor.java#L137) | 10 | 0% |
   <!-- | **Total:** | **14** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28795440/badge)](https://coveralls.io/builds/28795440) |
   | :-- | --: |
   | Change from base [Build 875](https://coveralls.io/builds/28793443): |  0.003% |
   | Covered Lines: | 11087 |
   | Relevant Lines: | 19236 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response
URL: https://github.com/apache/incubator-shardingsphere/pull/4353#issuecomment-587393669
 
 
   ## Pull Request Test Coverage Report for [Build 9634](https://coveralls.io/builds/28797369)
   
   * **6** of **7**   **(85.71%)**  changed or added relevant lines in **2** files are covered.
   * **112** unchanged lines in **7** files lost coverage.
   * Overall coverage decreased (**-0.02%**) to **57.61%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28797369/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L60) | 0 | 1 | 0.0%
   <!-- | **Total:** | **6** | **7** | **85.71%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28797369/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L46) | 2 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowIndexStatement.java](https://coveralls.io/builds/28797369/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowIndexStatement.java#L33) | 2 | 0% |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28797369/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/SelectStatement.java](https://coveralls.io/builds/28797369/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FSelectStatement.java#L61) | 5 | 28.57% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDALVisitor.java](https://coveralls.io/builds/28797369/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDALVisitor.java#L137) | 10 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/28797369/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L281) | 44 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDMLVisitor.java](https://coveralls.io/builds/28797369/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDMLVisitor.java#L314) | 46 | 0% |
   <!-- | **Total:** | **112** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28797369/badge)](https://coveralls.io/builds/28797369) |
   | :-- | --: |
   | Change from base [Build 875](https://coveralls.io/builds/28793443): |  -0.02% |
   | Covered Lines: | 11087 |
   | Relevant Lines: | 19245 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services