You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "xingtanzjr (via GitHub)" <gi...@apache.org> on 2023/06/14 02:42:26 UTC

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #10146: Validate tsfiles after compaction

xingtanzjr commented on code in PR #10146:
URL: https://github.com/apache/iotdb/pull/10146#discussion_r1228905384


##########
server/src/main/java/org/apache/iotdb/db/engine/compaction/execute/task/InnerSpaceCompactionTask.java:
##########
@@ -189,9 +189,9 @@ protected boolean doCompaction() {
           compactionLogger.logFile(targetTsFileResource, CompactionLogger.STR_DELETED_TARGET_FILES);
         }
 
-        if (IoTDBDescriptor.getInstance().getConfig().isEnableCompactionValidation()
-            && !CompactionUtils.validateTsFileResources(
-                tsFileManager, storageGroupName, timePartition)) {
+        CompactionValidator validator = CompactionValidator.getInstance();
+        if (!validator.validateCompaction(
+            tsFileManager, targetTsFileList, storageGroupName, timePartition)) {
           LOGGER.error(

Review Comment:
   Add more logs to illustrate why the validation is false. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org